Re: Re: PHP script for viewing subversion repositories
"Jay Freeman (saurik)" <[email protected]>
| Newsgroups | gmane.comp.horde.chora |
|---|---|
| Message-ID | <015d01c36d02$213bb870$fb590644@cruiser> |
Chuck: When you say "subclasses" you just mean "classes other than CVSLib/SVNLib itself", right? I don't remember seeing any inheritence, but I might have just not known how PHP handles that. I'll take care of this tonight and send a patch :). Sincerely, Jay Freeman (saurik) [email protected] ----- Original Message ----- From: "Chuck Hagenbuch" <[email protected]> To: "Jay Freeman (saurik)" <[email protected]> Cc: <[email protected]>; <[email protected]>; <[email protected]> Sent: Wednesday, August 27, 2003 7:49 PM Subject: Re: [chora] Re: PHP script for viewing subversion repositories > Quoting "Jay Freeman (saurik)" <[email protected]>: > > > Changing everything to use the VC global variable _seriously_ limits the > > usefulness of the library... in that last patch I believe I actually went to > > the trouble to change a few of those that I noticed that weren't needed (as > > this->rep was valid) to using this->rep. This assumes that you will only > > connect to one repository at a time... that's a really evil limitation for > > what's seeming like a rather good general purpose CVS/SVN library. > > Okay. I'd be happy to have everything have a reference to the base object, but > I'd like to see it done in a cleaner way if possible; something along the lines > of having a setVC() method in the subclasses that the base class could call > when instantiating it. > > I can try to look at this, but if you wanted to send a patch for it, I would > really really appreciate it. > > -chuck > > -- > Charles Hagenbuch, <[email protected]> > They're just looking at a wall of meat. -- Chora mailing list Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]