Re: Support for Windows Usernames
[email protected] Thu, 5 Feb 2004 22:51:48 EST
| Newsgroups | gmane.comp.horde.chora |
|---|---|
| Message-ID | <[email protected]> |
In a message dated 2/5/2004 11:02:33 AM Eastern Standard Time, [email protected] writes: Date: Wed, 4 Feb 2004 23:00:46 -0500 From: Jon Parise <[email protected]> Subject: Re: [chora] Support for Windows Usernames To: [email protected] Message-ID: <[email protected]> Content-Type: text/plain; charset=us-ascii On Wed, Feb 04, 2004 at 05:20:51PM -0500, [email protected] wrote: > I am aware of the fact that the files mentioned are no longer included in the > latest CVS version, but I could not find the place they were moved to, so I > just used the latest stable download. I am attaching a patch that was created > on mingw32 using 'diff -u', but has the path names from my computer in it. I don't have time to review the patch itself right now, but I can point you at the new location of these files: http://cvsweb.horde.org/cvs.php/framework/VC/ Ah, OK. Found the corresponding file there. ( http://cvsweb.horde.org/co.php/framework/VC/VC/cvs.php?r=1.7#884 ) Also, I think it would be swell if you could provide some sort of brief unit test that verifies that the function you modified now accepts the full range of expected username formats. I'm not sure I understand this... Could you give an example? -- Jon Parise ([email protected]) :: The Horde Project (http://horde.org/) Gordon Hemsley -- Chora mailing list - Join the hunt: http://horde.org/bounties/#chora Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]