Re: commit: framework/Imap_Client/lib/Horde/Imap Client.php
Michael M Slusarz <[email protected]>
| Newsgroups | gmane.comp.horde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Quoting Chuck Hagenbuch <[email protected]>: > Quoting Michael M Slusarz <[email protected]>: > >> slusarz 2008-10-28 23:03:34 EDT >> >> Modified files: >> Imap_Client/lib/Horde/Imap Client.php >> Log: >> Horde Autoloader doesn't load the MIME/Util libraries (they are >> not prefixed >> with Horde) so have the lib autoloader handle all lib loading. > > As an interim step I guess this is okay, but the calling code should > be responsible for either including classes or setting up an > autoloader. Renaming the MIME libs to be Horde_Mime will allow > regular autoloading. And having other, random autoload code in > various framework packages is something I'm very much against. Again, though, what is the alternative if Horde_Imap_Client is meant to be used completely separate of Horde (I've already had several inquiries for using the client lib without using any of the optional Horde libs)? And using this autoload stuff breaks the previous behavior for some of these require/includes, which is if the library is not available disable that feature (I'm guessing autoload wasn't really designed for this purpose). Now if the library is not available, the entire script dies, which isn't very helpful. That is why, playing with autoload stuff today, I've come to the realization it is kind of worthless. It causes just as many problems as it fixes. michael -- ___________________________________ Michael Slusarz [[email protected]] -- To unsubscribe, mail: [email protected]