Re: commit: gollem login.php gollem/docs CHANGES

Michael Rubinsky <[email protected]>
Newsgroups gmane.comp.horde.cvs,gmane.comp.horde.devel
Message-ID <[email protected]>
Quoting Chuck Hagenbuch <[email protected]>:

> Quoting Michael Rubinsky <[email protected]>:
>
>>  Log:
>>  Make sure that the backend_key parameter is not hidden with the url
>> parameter.
>>
>>  This would happen if being redirected here via a
>> authenticationFailureRedirect
>>  and could cause the wrong backend to be selected if more than one
>> backend is
>>  configured.
>
>>  Can another dev sanity check me?
>
>> http://cvs.horde.org/diff.php/gollem/login.php?rt=horde&r1=1.127&r2=1.128&ty=u
>
> This doesn't seem right to me. Shouldn't we just pass the parameter  
> correctly in the first place?

Ideally, yes.  Though I don't see how to do that while going through  
Horde::authenticationFailureRedirect() - unless we're talking about  
giving Gollem it's own version of that method.


-- 
Thanks
Mike

"Time just hates me, that's why it made me an adult." - Josh Joplin

--
To unsubscribe, mail: [email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.