Re: [commits] Horde branch master updated. 86ef55186f749ab0a37e0d6389ddb75e13e9a66e
Michael M Slusarz <[email protected]>
| Newsgroups | gmane.comp.horde.devel |
|---|---|
| Message-ID | <20140320153701.Horde.gqkNZX6mR4mgjXabbZMhdg9@bigworm.curecanti.org> |
Quoting Michael J Rubinsky <[email protected]>: > Quoting Michael M Slusarz <[email protected]>: > >> commit d2cd083472aae600ab4382ac35cc701314b63933 >> Author: Michael M Slusarz <[email protected]> >> Date: Tue Mar 18 13:35:09 2014 -0600 >> >> Revert "Use the default SMTP port of 25, not the MSA port of 587." >> >> This reverts commit 3f373410d7d68db94f209efb09c67e343764516f. >> >> Conflicts: >> framework/Smtp/lib/Horde/Smtp.php >> >> This was incorrect. Horde_Smtp, as of 1.0.0, used 587 by default. If >> Horde the application defaulted to port 25, that needs to be addressed >> at the Horde-level instantiation, not in this package. >> >> framework/Smtp/lib/Horde/Smtp.php | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> http://github.com/horde/horde/commit/d2cd083472aae600ab4382ac35cc701314b63933 >> http://git.horde.org/horde-git/-/commit/d2cd083472aae600ab4382ac35cc701314b63933 > > This a BC break. Your logic is revesed - it fixes a BC break. Horde_Smtp 1.0.0 shipped with the port as 587. Changing that value in a version > 1.0.0 breaks BC with Horde_Smtp version 1.0.0. > If Horde_Smtp is upgraded, but Horde is not, the user will > potentially be unable to send email. If you are talking about the fact that H5 has a configuration file that defaults to sending SMTP on port 25, that has nothing to do with backward compatibility in the Horde_Smtp package. When we switched to using Horde_Smtp sometime during H5, and didn't correctly set the port when instantiating Horde_Smtp, that was an implementation bug in **horde**, not a logic/configuration bug in Horde_Smtp. Thus, it needed to be fixed in horde, not Horde_Smtp (which was done). I can simply flip your logic and say "What if Horde is upgraded and Horde_Smtp is not?" and, without fixes in Horde_Core, this issue would never be fixed. michael ___________________________________ Michael Slusarz [[email protected]] -- dev mailing list Frequently Asked Questions: http://wiki.horde.org/FAQ To unsubscribe, mail: [email protected]