Re: [commits] Horde branch master updated. ee59badf9c55a570a75be9df20b29e24effc8335
Jan Schneider <[email protected]>
| Newsgroups | gmane.comp.horde.devel |
|---|---|
| Message-ID | <[email protected]> |
On 29. August 2014 20:58:37 MESZ, Michael M Slusarz <[email protected]> wrote: >Quoting Jan Schneider <[email protected]>: > >> commit ee59badf9c55a570a75be9df20b29e24effc8335 >> Author: Jan Schneider <[email protected]> >> Date: Fri Aug 29 11:08:27 2014 +0200 >> >> Revert "Yay! Headers are no longer broken by long strings" >> >> This is obviously not an option. Individual applications cannot >> override global >> styles for consistency reasons. And the bottom line in the >> background image has >> some design/UI function. >> >> This reverts commit 020df072ad74c791ab45b960e3f2e7f4a6f3090d. >> >> imp/themes/default/screen.css | 5 ----- >> 1 files changed, 0 insertions(+), 5 deletions(-) >> >> >http://github.com/horde/horde/commit/ee59badf9c55a570a75be9df20b29e24effc8335 > >This is just incorrect. Have a UI expert from one of my clients who >can't stress to me how wrong this is to be used in situation where the > >length of the header cannot be determined with certainty. > >I'm just going to remove .header from use in IMP if this is going to >stay then, because everywhere we use it there I can provide 10 >examples of how I can break it. So that's obviously not the correct >solution in that app. > >michael > >___________________________________ >Michael Slusarz [[email protected]] > >-- >dev mailing list >Frequently Asked Questions: http://wiki.horde.org/FAQ >To unsubscribe, mail: [email protected] But changing it in just one app isn't a solution either. Removing .header isn't one either, because it's consistency breaking too. Provide a global solution, that doesn't break the design in other apps, and we're fine. -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. -- dev mailing list Frequently Asked Questions: http://wiki.horde.org/FAQ To unsubscribe, mail: [email protected]