Re: [commits] Horde branch master updated. f3f63ebd0015bc67ea9ba715f737f6355520b909
Jan Schneider <[email protected]>
| Newsgroups | gmane.comp.horde.devel |
|---|---|
| Message-ID | <[email protected]> |
Zitat von Michael M Slusarz <[email protected]>: > Quoting Jan Schneider <[email protected]>: > >> commit 2691fc5244ed2eec6578288b7f3183c93ccb2c70 >> Author: Jan Schneider <[email protected]> >> Date: Tue Nov 18 15:09:18 2014 +0100 >> >> Indention >> >> framework/Mime/lib/Horde/Mime/Headers.php | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> http://github.com/horde/horde/commit/2691fc5244ed2eec6578288b7f3183c93ccb2c70 > > No, this is actually correct. > > I recently learned this is the "correct" formatting for all > subsequent lines in a class declaration, at least given our current > standards. (Of course, I can't exactly recall where I saw this.) > And I agree - we indent everything else (other than switch case > statements) that is a continuation. This is nowhere mentioned in our written down standards AFAICS, but we have a defacto standard in existing code that lines everything up. PSR-2, which we should follow in Horde 6, since it's already almost identical to the Horde CS (and of course originates in Horde CS), has a slightly different approach. It only allows wrapping of interfaces, and then ... well see yourself in section 4.1: http://www.php-fig.org/psr/psr-2/ -- Jan Schneider The Horde Project http://www.horde.org/ https://www.facebook.com/hordeproject -- dev mailing list Frequently Asked Questions: http://wiki.horde.org/FAQ To unsubscribe, mail: [email protected]