Re: [commits] Horde branch master updated. a61da56f8c575c7da9c2c018a350119e4301a472
Jan Schneider <[email protected]>
| Newsgroups | gmane.comp.horde.devel |
|---|---|
| Message-ID | <[email protected]> |
Zitat von Ralf Lang <[email protected]>: > On 27.04.2015 09:00, Jan Schneider wrote: >> >> Zitat von Michael J Rubinsky <[email protected]>: >> >>> Quoting Jan Schneider <[email protected]>: >>> >>>>> commit a61da56f8c575c7da9c2c018a350119e4301a472 >>>>> Author: Michael J Rubinsky <[email protected]> >>>>> Date: Fri Apr 24 10:32:55 2015 -0400 >>>>> >>>>> Ensure admins see all system shares. >>>>> >>>>> This is why my system shares were not included in listShares. >>>>> If they are created, but don't explicitly have permissions set for >>>>> at least PERMS_VIEW, they will not be returned. >>>>> >>>>> kronolith/lib/Shares.php | 10 +++++++++- >>>>> 1 files changed, 9 insertions(+), 1 deletions(-) >>>>> >>>>> http://github.com/horde/horde/commit/a61da56f8c575c7da9c2c018a350119e4301a472 >>>>> >>>> >>>> This is intended. System share should for admins only show up in the >>>> system shares section, not in the regular section. For non-admin >>>> users, the system shares should show up in the shared calendars >>>> section, if they have sufficient perms. >>> >>> This didn't have anything to do with what section they show up in. If >>> you create a system share, but do not explicitly set any permissions >>> on it, it will not be viewable _at_all_, to anyone, ever. This commit >>> fixes them not showing up in the system shares section for admins only. >> >> But since listSystemShares() doesn't do permission checking, they should >> still show up in the system calendars section, no matter if permissions >> have been set or not. > > At least we should not face a situation where an admin cannot grant > permissions to anybody because he does not "see" the system shares anywhere. Yes, of course ;-) -- Jan Schneider The Horde Project http://www.horde.org/ https://www.facebook.com/hordeproject -- dev mailing list Frequently Asked Questions: http://wiki.horde.org/FAQ To unsubscribe, mail: [email protected]