Re: [commits] Horde branch master updated. dd271604ce632fffe27e93c76d67250153d8a7ca

Quoting Jan Schneider <[email protected]>:

> Zitat von Michael J. Rubinsky <[email protected]>:
>
>> The branch "master" has been updated.
>> The following is a summary of the commits.
>>
>> from: 262144163246f3e7c975cfea041cc609d764765a
>>
>> dd27160 Revert "Don't read the whole result set at once."
>>
>> Summary:  
>> http://github.com/horde/horde/compare/262144163246f3e7c975cfea041cc609d764765a...dd271604ce632fffe27e93c76d67250153d8a7ca
>>
>> -----------------------------------------------------------------------
>>
>> commit dd271604ce632fffe27e93c76d67250153d8a7ca
>> Author: Michael J Rubinsky <[email protected]>
>> Date:   Wed May 13 13:17:51 2015 -0400
>>
>>    Revert "Don't read the whole result set at once."
>>
>>    Not sure what this was trying to do, but:
>>
>>    ::select() only returns a single row, so the iterations
>>    that are supposed to act on the result set won't work.
>>
>>    Fixes broken history tests and imp migration.
>>
>>    This reverts commit 0373a92f354a24c1dd91d3a066ab41af498a169c.
>>
>> .../migration/Horde/History/3_horde_history_add_modseq.php        |    2 +-
>> imp/migration/3_imp_maillog_update.php                            |  
>>    4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> http://github.com/horde/horde/commit/dd271604ce632fffe27e93c76d67250153d8a7ca
>
> It doesn't return a row, but a result set, that is an iterator.


Hm. Yeah, the phpdoc was confusing for me - the descriptions says it  
returns an array keyed by column names, but @return shows the  
presumably correct result object being returned.

Regardless, the History unit tests fail badly with this commit.

-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-- 
dev mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: [email protected]