Re: [commits] Horde branch master updated. 2e6b529de5e601153730f0761baed27bf6db594b

Quoting Jan Schneider <[email protected]>:

> commit bad7f2ecdc703decff4007f53509cd19d07359b0
> Author: Jan Schneider <[email protected]>
> Date:   Mon Nov 23 16:48:46 2015 +0100
>
>     Enforce sending of ID request after login.
>
>     This request was queued instead, and sent during shutdown  
> scripts. For some
>     reason the streams were empty during shutdown here. Mabye  
> streams are closed or
>     emptied during shutdown and for some reason this happened before  
> the other
>     shutdown scripts here. I don't know. This fixes it.
>
>  framework/Imap_Client/lib/Horde/Imap/Client/Base.php |    2 ++
>  framework/Imap_Client/package.xml                    |    4 +++-
>  2 files changed, 5 insertions(+), 1 deletions(-)
>
> http://github.com/horde/horde/commit/bad7f2ecdc703decff4007f53509cd19d07359b0

This needs to be reverted - in fact, this was the whole purpose of  
implementing pipelining in the first place.

There is zero reason we should be sending an ID command in its own  
round trip (especially since the current PHP IMAP client works  
synchronously).  And ID command only makes sense when it can piggy  
back on another command that is required for program flow.

If the stream is somehow being destroyed at shutdown before we can  
read it, then we need to ignore.

michael

___________________________________
Michael Slusarz [[email protected]]

-- 
dev mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: [email protected]