Re: [commits] Horde branch master updated. 88679069d1c1d9759b468e93356514aa86488796

Quoting Jan Schneider <[email protected]>:

> The branch "master" has been updated.
> The following is a summary of the commits.
>
> from: 33f34fbd07e5623a7f1c8e85ee2473f370a3f43f
>
> 18c8fe3 Horde_Stream is a dep now.
> baa79ba Actually no need for Horde_Stream at all.
> c5eb4ce phpdoc
> ea32d50 Make the $value a string-only property again.
> f94c458 Make streams work with Oracle too (Request #10805).
> 8867906 Actually test that BLOBS are correctly written (Request #10805).
>
> Summary:  
> http://github.com/horde/horde/compare/33f34fbd07e5623a7f1c8e85ee2473f370a3f43f...88679069d1c1d9759b468e93356514aa86488796
>
> -----------------------------------------------------------------------
>
> commit 18c8fe394ff001d83e77b73ca964779f8c6d719d
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 15:57:36 2017 +0100
>
>     Horde_Stream is a dep now.
>
>  framework/Vfs/package.xml | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> http://github.com/horde/horde/commit/18c8fe394ff001d83e77b73ca964779f8c6d719d
>
> -----------------------------------------------------------------------
>
> commit baa79bafcbc4d3ff5a49586a7d49c97defda1075
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 16:02:00 2017 +0100
>
>     Actually no need for Horde_Stream at all.
>
>  framework/Vfs/lib/Horde/Vfs/Base.php | 6 +++---
>  framework/Vfs/package.xml            | 7 -------
>  2 files changed, 3 insertions(+), 10 deletions(-)
>
> http://github.com/horde/horde/commit/baa79bafcbc4d3ff5a49586a7d49c97defda1075
>
> -----------------------------------------------------------------------
>
> commit c5eb4ce0dc2ffbe46a6708f44a0953f8c7ee48ab
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 17:35:34 2017 +0100
>
>     phpdoc
>
>  framework/Db/lib/Horde/Db/Adapter/Base.php     | 11 ++++++-----
>  framework/Db/lib/Horde/Db/Adapter/Oci8.php     | 12 ++++++------
>  framework/Db/lib/Horde/Db/Adapter/Pdo/Base.php |  8 ++++----
>  3 files changed, 16 insertions(+), 15 deletions(-)
>
> http://github.com/horde/horde/commit/c5eb4ce0dc2ffbe46a6708f44a0953f8c7ee48ab
>
> -----------------------------------------------------------------------
>
> commit ea32d50494dcadacd5173f8059f6f49f8b3dfbf1
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 17:36:53 2017 +0100
>
>     Make the $value a string-only property again.
>
>     It's a BC break that this might sometimes be a stream now.  
> Instead make $value a setter/getter and add $stream property too.  
> Convert between these two on the fly.
>     Also make Horde_Db_Value_Text extend Horde_Db_Value_Binary  
> because they share most of the code. This requires to change some  
> class tests though, because "instanceof Horde_Db_Value_Binary" is  
> true now for Value_Text objects too.


Wouldn't changing the class inheritance hierarchy of a public class be  
a BC break as well? As you said, you nee

Also, is $value being set to a stream really a BC break? This is only  
the case when insert/updating a blob column, so it's the client code  
that is setting it to a stream - which means it must already have a  
dependency on a version of Horde_Db that can support it. Or did I  
misunderstand something?



>     Request: 10805
>
>  framework/Db/lib/Horde/Db/Adapter/Base.php     |  2 +-
>  framework/Db/lib/Horde/Db/Adapter/Oci8.php     |  8 +--
>  framework/Db/lib/Horde/Db/Adapter/Pdo/Base.php |  8 +--
>  framework/Db/lib/Horde/Db/Value/Binary.php     | 89  
> ++++++++++++++++++++------
>  framework/Db/lib/Horde/Db/Value/Text.php       | 25 +-------
>  5 files changed, 80 insertions(+), 52 deletions(-)
>
> http://github.com/horde/horde/commit/ea32d50494dcadacd5173f8059f6f49f8b3dfbf1
>
> -----------------------------------------------------------------------
>
> commit f94c4588c737cd17c9374099ef256e0193cef0c0
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 17:42:05 2017 +0100
>
>     Make streams work with Oracle too (Request #10805).
>
>  framework/Db/lib/Horde/Db/Adapter/Oci8.php      | 6 +++++-
>  framework/Db/test/Horde/Db/Adapter/TestBase.php | 2 +-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> http://github.com/horde/horde/commit/f94c4588c737cd17c9374099ef256e0193cef0c0
>
> -----------------------------------------------------------------------
>
> commit 88679069d1c1d9759b468e93356514aa86488796
> Author: Jan Schneider <[email protected]>
> Date:   Fri Feb 3 17:42:54 2017 +0100
>
>     Actually test that BLOBS are correctly written (Request #10805).
>
>  framework/Db/test/Horde/Db/Adapter/TestBase.php | 29  
> +++++++++++++++++++++----
>  1 file changed, 25 insertions(+), 4 deletions(-)
>
> http://github.com/horde/horde/commit/88679069d1c1d9759b468e93356514aa86488796
>
>
> --
> commits mailing list
> Frequently Asked Questions: http://wiki.horde.org/FAQ
> To unsubscribe, mail: [email protected]



-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-- 
dev mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: [email protected]