Re: Events longer than one day do not display correctly when they have recurrence

Quoting Pascal Rigaux <[email protected]>:

> Hi,
>
> I was looking at issue https://bugs.horde.org/ticket/4438 :
> In kronolith dynamic view, events longer than one day do not display  
> correctly when they have recurrence.
>
> I know the issue "Recurring events overlapping days incorrectly  
> shown" is complex
> ( https://bugs.horde.org/ticket/12488 )
>
> But I still think a cleanup could fix the weekly dynamic view on non  
> overlapping events:
>
> Kronolith::addEvents() with $covertDates:
>
> - for recurring events : uses Kronolith::addCoverDates()
>
> - for non recurring events : uses code similar toKronolith::addCoverDates(),
>   but for days in between the start and end day, the range is  
> midnight to midnight,
>   and for the edge days it's start to midnight, and midnight to end.
>
> I see no reason why recurring events should return a different kind of value.
> This breaks badly the display in dynamic view (cf screenshot).
> (NB: non dynamic view works correctly)
>
> The following patch ensures recurring and non recurring events are  
> treated equally:
> https://github.com/prigaux/horde/commit/926601bd7a7b5527262ee0f74ac3b4c4b95f99c6
>
> This fixes weekly dynamic view.
>
> WYT?

Cleaned up a bit and committed to master, thanks!

> cu
>
> -- 
> Pascal Rigaux



-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-- 
kronolith mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: [email protected]