Re: Development status of SAM module? Need a developer?
John Dalbec <[email protected]> Wed, 05 Nov 2003 17:10:08 -0500
| Newsgroups | gmane.comp.horde.sam |
|---|---|
| Message-ID | <[email protected]> |
Damian Gerow wrote: > Thus spake John Dalbec ([email protected]) [05/11/03 14:35]: > >>The attached patch: >> >>1) Makes the 'flag' filename, FTP hostname, and FTP port configuration >>items. >>2) Updates the (en_US) help text for report_safe. >>3) Converts the "report_safe" checkbox to radio buttons to allow selection >>of "report_safe 2" (the default here). I thought about making it a >>drop-down selection but AFAIK this requires javascript and there's no >>javascript.inc file. > > > Thanks! I have a gripe with point number 1, though... > > The FTP host really should be configurable based on the login realm. As it > stands right now, I'm just assuming that the realm is a machine name, and > FTP'ing to that machine. I've taken a look at the other realm FTP host > configurations, and I think I have an idea of what to do, I just haven't had > the time to do it. I forgot to mention that my patch is against the Horde 2.x backport, in which you hard-code "mail.example.org" as the FTP host in enabledisable.php. I presume the behavior you're describing is that of CVS HEAD? John > > So I'll merge in 2 and 3, but leave out 1 for now, until I clean it all up a > bit more. > > - Damian > > -- sam mailing list Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]