Re: Passwd tab sequencing

--bcaec5485950b6d32904b15109de
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 9 November 2011 10:30, Simon Brereton <[email protected]> wr=
ote:
> On 9 November 2011 08:55, Jan Schneider <[email protected]> wrote:
>>
>> Zitat von Simon Brereton <[email protected]>:
>>
>>> Hi
>>>
>>> I have two minor UI suggestions for the passwd module.
>>>
>>> Firstly, the username comes prefilled (if supported), which is nice.
>>> However, if the browser has save the password, this is also
>>> pre-filled. =C2=A0Whilst this is nice because it means the browser will
>>> request to update the password after a successful change it is also a
>>> danger. =C2=A0Users who stay logged in can have their password changed
>>> (either maliciously or not) because the authentication is already
>>> there. =C2=A0It would be better not to pre-fill that field, or other ha=
ve
>>> some other two-step authentication verification.
>>
>> Like you already said, this is a browser feature.
>
> It's been a long long time since I did any web coding. =C2=A0But I seem t=
o
> recall (and other sites manage it) that if you rename the password
> field then the browser won't fill it.
>
>>> Secondly, users are capable or and used to using the tab key to move
>>> between form fields. =C2=A0However, in the passwd module the tab key ta=
kes
>>> you to the help icons (which if you have a resolution bigger then
>>> 1024x768) are miles away from what they relate to.
>>>
>>> I would propose therefore to make the tab sequencing..
>>>
>>> Username:
>>> Old password:
>>> New password:
>>> Confirm new password:
>>> Change Password
>>> Reset
>>> Username Help
>>> Old password Help
>>> New password Help
>>> Confirm new password Help
>>
>> Patch?
>
> See above. =C2=A0I would love to contribute but seriously it would take
> more time for me to fix it than it would for you to build H5. =C2=A0And
> then you'd still have to fix it. =C2=A0But I'll take a look :)

Here's a patch.  It correctly changes the tab order (although because
of the way the help icons are built those are moved right to the end
of the sequence.  I'm sure someone with more familiarity or the horde
framework could correct that) for me to be able to move from field to
field and then to submit/reset.

It also stops the password from being loaded with the form - but for
some reason despite the fact that stackoverflow (and mozilla) assured
me it would stop the old password from loading as soon as you tab into
the field it does load.  Still it's a start.  It could also just be my
browser (Firefox on Ubuntu 10.10).

Simon

--bcaec5485950b6d32904b15109de
Content-Type: application/octet-stream; 
	name="passwd.template.index.html.php.patch"
Content-Disposition: attachment; 
	filename="passwd.template.index.html.php.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gusmnkzl1

KioqIC91c3Ivc2hhcmUvaG9yZGU0L3Bhc3N3ZC90ZW1wbGF0ZXMvaW5kZXguaHRtbC5waHAgICAy
MDExLTExLTA5IDE3OjUwOjM0LjAwMDAwMDAwMCArMDAwMAotLS0gL3Vzci9zaGFyZS9ob3JkZTQv
cGFzc3dkL3RlbXBsYXRlcy9pbmRleC5odG1sLmxvY2FsLnBocCAgICAgMjAxMS0xMS0wOSAxNzo0
NzowOC4wMDAwMDAwMDAgKzAwMDAKKioqKioqKioqKioqKioqCioqKiAxNywyMyAqKioqCiAgICA8
c3Ryb25nPjw/cGhwIGVjaG8gJHRoaXMtPmxhYmVsLT51c2VyaWQgPz48L3N0cm9uZz4KICAgPC90
ZD4KICAgPHRkPgohICAgPGlucHV0IHR5cGU9InRleHQiIGlkPSJ1c2VyaWQiIG5hbWU9InVzZXJp
ZCIgdmFsdWU9Ijw/cGhwIGVjaG8gJHRoaXMtPmgoJHRoaXMtPnVzZXJpZCkgPz4iIC8+CiAgIDwv
dGQ+CiAgIDx0ZCBjbGFzcz0icmlnaHRBbGlnbiI+CiAgICA8P3BocCBlY2hvICR0aGlzLT5oZWxw
LT51c2VybmFtZSA/PgotLS0gMTcsMjMgLS0tLQogICAgPHN0cm9uZz48P3BocCBlY2hvICR0aGlz
LT5sYWJlbC0+dXNlcmlkID8+PC9zdHJvbmc+CiAgIDwvdGQ+CiAgIDx0ZD4KISAgIDxpbnB1dCB0
eXBlPSJ0ZXh0IiBpZD0idXNlcmlkIiBuYW1lPSJ1c2VyaWQiIHRhYmluZGV4PSIxIiB2YWx1ZT0i
PD9waHAgZWNobyAkdGhpcy0+aCgkdGhpcy0+dXNlcmlkKSA/PiIgLz4KICAgPC90ZD4KICAgPHRk
IGNsYXNzPSJyaWdodEFsaWduIj4KICAgIDw/cGhwIGVjaG8gJHRoaXMtPmhlbHAtPnVzZXJuYW1l
ID8+CioqKioqKioqKioqKioqKgoqKiogMzAsMzYgKioqKgogICAgPHN0cm9uZz48P3BocCBlY2hv
ICR0aGlzLT5sYWJlbC0+b2xkcGFzc3dvcmQgPz48L3N0cm9uZz4KICAgPC90ZD4KICAgPHRkPgoh
ICAgPGlucHV0IHR5cGU9InBhc3N3b3JkIiBpZD0ib2xkcGFzc3dvcmQiIG5hbWU9Im9sZHBhc3N3
b3JkIiBzaXplPSIzMiIgLz4KICAgPC90ZD4KICAgPHRkIGNsYXNzPSJyaWdodEFsaWduIj4KICAg
IDw/cGhwIGVjaG8gJHRoaXMtPmhlbHAtPm9sZHBhc3N3b3JkID8+Ci0tLSAzMCwzNiAtLS0tCiAg
ICA8c3Ryb25nPjw/cGhwIGVjaG8gJHRoaXMtPmxhYmVsLT5vbGRwYXNzd29yZCA/Pjwvc3Ryb25n
PgogICA8L3RkPgogICA8dGQ+CiEgICA8aW5wdXQgdHlwZT0icGFzc3dvcmQiIGlkPSJvbGRwYXNz
d29yZCIgbmFtZT0ib2xkcGFzc3dvcmQiIHRhYmluZGV4PSIyIiBhdXRvY29tcGxldGU9Im9mZiIg
c2l6ZT0iMzIiIC8+CiAgIDwvdGQ+CiAgIDx0ZCBjbGFzcz0icmlnaHRBbGlnbiI+CiAgICA8P3Bo
cCBlY2hvICR0aGlzLT5oZWxwLT5vbGRwYXNzd29yZCA/PgoqKioqKioqKioqKioqKioKKioqIDQy
LDQ4ICoqKioKICAgIDxzdHJvbmc+PD9waHAgZWNobyAkdGhpcy0+bGFiZWwtPm5ld3Bhc3N3b3Jk
MCA/Pjwvc3Ryb25nPgogICA8L3RkPgogICA8dGQ+CiEgICA8aW5wdXQgdHlwZT0icGFzc3dvcmQi
IGlkPSJuZXdwYXNzd29yZDAiIG5hbWU9Im5ld3Bhc3N3b3JkMCIgc2l6ZT0iMzIiIC8+CiAgIDwv
dGQ+CiAgIDx0ZCBjbGFzcz0icmlnaHRBbGlnbiI+CiAgICA8P3BocCBlY2hvICR0aGlzLT5oZWxw
LT5uZXdwYXNzd29yZCA/PgotLS0gNDIsNDggLS0tLQogICAgPHN0cm9uZz48P3BocCBlY2hvICR0
aGlzLT5sYWJlbC0+bmV3cGFzc3dvcmQwID8+PC9zdHJvbmc+CiAgIDwvdGQ+CiAgIDx0ZD4KISAg
IDxpbnB1dCB0eXBlPSJwYXNzd29yZCIgaWQ9Im5ld3Bhc3N3b3JkMCIgbmFtZT0ibmV3cGFzc3dv
cmQwIiB0YWJpbmRleD0iMyIgc2l6ZT0iMzIiIC8+CiAgIDwvdGQ+CiAgIDx0ZCBjbGFzcz0icmln
aHRBbGlnbiI+CiAgICA8P3BocCBlY2hvICR0aGlzLT5oZWxwLT5uZXdwYXNzd29yZCA/PgoqKioq
KioqKioqKioqKioKKioqIDU0LDYwICoqKioKICAgIDxzdHJvbmc+PD9waHAgZWNobyAkdGhpcy0+
bGFiZWwtPm5ld3Bhc3N3b3JkMSA/Pjwvc3Ryb25nPgogICA8L3RkPgogICA8dGQ+CiEgICA8aW5w
dXQgdHlwZT0icGFzc3dvcmQiIGlkPSJuZXdwYXNzd29yZDEiIG5hbWU9Im5ld3Bhc3N3b3JkMSIg
c2l6ZT0iMzIiIC8+CiAgIDwvdGQ+CiAgIDx0ZCBjbGFzcz0icmlnaHRBbGlnbiI+CiAgICA8P3Bo
cCBlY2hvICR0aGlzLT5oZWxwLT5jb25maXJtcGFzc3dvcmQgPz4KLS0tIDU0LDYwIC0tLS0KICAg
IDxzdHJvbmc+PD9waHAgZWNobyAkdGhpcy0+bGFiZWwtPm5ld3Bhc3N3b3JkMSA/Pjwvc3Ryb25n
PgogICA8L3RkPgogICA8dGQ+CiEgICA8aW5wdXQgdHlwZT0icGFzc3dvcmQiIGlkPSJuZXdwYXNz
d29yZDEiIG5hbWU9Im5ld3Bhc3N3b3JkMSIgdGFiaW5kZXg9IjQiIHNpemU9IjMyIiAvPgogICA8
L3RkPgogICA8dGQgY2xhc3M9InJpZ2h0QWxpZ24iPgogICAgPD9waHAgZWNobyAkdGhpcy0+aGVs
cC0+Y29uZmlybXBhc3N3b3JkID8+CioqKioqKioqKioqKioqKgoqKiogODEsODggKioqKgoKICA8
dHIgY2xhc3M9ImNvbnRyb2wiPgogICA8dGQgY29sc3Bhbj0iMyIgY2xhc3M9ImNvbnRyb2wiPgoh
ICAgPGlucHV0IGNsYXNzPSJidXR0b24iIHR5cGU9InN1Ym1pdCIgbmFtZT0ic3VibWl0IiBpZD0i
c3VibWl0IiB2YWx1ZT0iPD9waHAgZWNobyBfKCJDaGFuZ2UgUGFzc3dvcmQiKSA/PiIgLz4KISAg
IDxpbnB1dCBjbGFzcz0iYnV0dG9uIiB0eXBlPSJyZXNldCIgbmFtZT0icmVzZXQiIHZhbHVlPSI8
P3BocCBlY2hvIF8oIlJlc2V0IikgPz4iIC8+CiAgIDwvdGQ+CiAgPC90cj4KICA8L3RhYmxlPgot
LS0gODEsODggLS0tLQoKICA8dHIgY2xhc3M9ImNvbnRyb2wiPgogICA8dGQgY29sc3Bhbj0iMyIg
Y2xhc3M9ImNvbnRyb2wiPgohICAgPGlucHV0IGNsYXNzPSJidXR0b24iIHR5cGU9InN1Ym1pdCIg
bmFtZT0ic3VibWl0IiBpZD0ic3VibWl0IiB0YWJpbmRleD0iNSIgdmFsdWU9Ijw/cGhwIGVjaG8g
XygiQ2hhbmdlIFBhc3N3b3JkIikgPz4iIC8+CiEgICA8aW5wdXQgY2xhc3M9ImJ1dHRvbiIgdHlw
ZT0icmVzZXQiIG5hbWU9InJlc2V0IiB0YWJpbmRleD0iNiIgdmFsdWU9Ijw/cGhwIGVjaG8gXygi
UmVzZXQiKSA/PiIgLz4KICAgPC90ZD4KICA8L3RyPgogIDwvdGFibGU+Cg==
--bcaec5485950b6d32904b15109de
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

-- 
Sork mailing list - Join the hunt: http://horde.org/bounties/#sork
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: [email protected]

--bcaec5485950b6d32904b15109de--