Re: Syncing with the P1i
Jan Schneider <[email protected]>
| Newsgroups | gmane.comp.horde.sync |
|---|---|
| Message-ID | <[email protected]> |
Zitat von Jan Schneider <[email protected]>: > Zitat von Martin Zoller <[email protected]>: > >> Hello >> >> I think you're right about the linebreak, Jan. But that would mean that >> *Horde* doesn't count it, because the higher number (153 bytes) comes >> from the *phone*. That's because the data already gets trimmed: In >> Command/Sync.php on line 225. > > Gotcha! I got the numbers wrong, so this seems to be a bug in Horde. > >> Now that we have this explanation for the size mismatch, it wouldn't be >> too elegant to just accept "wrong" size specifications as in Arvid's >> patch. Maybe we should store the 'trimmed' and the 'untrimmed' length of >> the data and accept both of them? Because removing the trim() commands >> might break other clients. > > Well, if it does, then *those* clients are broken, and we have to > find a workaround for it. I guess it works for most clients, because > they don't include a trailing CRLF. Try this: http://cvs.horde.org/diff.php/framework/SyncML/SyncML/Command/Sync.php?rt=horde&r1=1.17.10.18&r2=1.17.10.19&ty=u Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/ -- sync mailing list - Join the hunt: http://horde.org/bounties/#sync Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]