Re: ActiveSync PHP errors after upgrade

Michael J Rubinsky <[email protected]> Wed, 28 Nov 2018 14:50:03 +0000
Newsgroups	gmane.comp.horde.user
Message-ID	<20181128145003.Horde.TcPpbJdW8J0hmVqCCJhWbjo@tarn.theupstairsroom.com>
Quoting Nels Lindquist <[email protected]>:

> On 2018/11/23 2:06 p.m., Michael J Rubinsky wrote:
>>
>> Quoting Nels Lindquist <[email protected]>:
>>
>>> On 2018/11/23 11:51 a.m., Michael J Rubinsky wrote:
>>>>
>>>> Quoting Nels Lindquist <[email protected]>:
>>>>
>>>>> Since upgrading Horde with PEAR to the latest available
>>>>> earlier this week, I'm seeing a bunch of error messages in
>>>>> syslog of the form:
>>>>>
>>>>> HORDE: PHP ERROR: implode(): Invalid arguments passed [pid
>>>>> 27975 on line 493 of
>>>>> "/usr/share/pear/Horde/ActiveSync/State/Sql.php"].
>>>>>
>>>>> I have ActiveSync logging enabled for the domain in question,
>>>>> but I'm not seeing any matching errors in the per-device
>>>>> logs, so I'm not sure how worried to be.
>>>>>
>>>>> Some quick searching hasn't turned up anything.
>>>>>
>>>>> Environment is CentOS 6 with Webtatic PHP 5.6 packages
>>>>> installed; PostgreSQL database.
>>>>>
>>>>> Horde Groupware Webmail edition 5.2.22 IMP version 6.2.22
>>>>> Horde_ActiveSync version 2.39.4
>>>>
>>>> Are you sure you have the most up to date Horde_Core library?
>>>> This was fixed back in July.
>>>>
>>>> https://github.com/horde/Core/commit/24e6e44e858e391c8c847c9c445c0057b
>>>
>>>>
> 30655e2#diff-3a683241c12c06bd12e14c869cd0983d
>>>
>>> From
>>>>
>>> "pear list -c horde":
>>>
>>> Horde_Core    2.31.6    stable
>>>
>>> I checked /usr/share/pear/Horde/Core/ActiveSync/Driver.php and
>>> it definitely has the patch you linked applied.
>>
>> Can you provide a snippit of the synclog that shows the incoming
>> change that causes this?
>>
>> Something like:
>>
>> [6741][2018-11-23T21:05:14+00:00] I:     <Modify>
>> [6741][2018-11-23T21:05:14+00:00] I:      <ServerEntryId>
>> [6741][2018-11-23T21:05:14+00:00] I:        398024
>> [6741][2018-11-23T21:05:14+00:00] I:      </ServerEntryId>
>> [6741][2018-11-23T21:05:14+00:00] I:      <Data>
>> [6741][2018-11-23T21:05:14+00:00] I:       <POOMMAIL:Categories>
>> [6741][2018-11-23T21:05:14+00:00] I:        <POOMMAIL:Category>
>> [6741][2018-11-23T21:05:14+00:00] I:          ActiveSync
>> [6741][2018-11-23T21:05:14+00:00] I:        </POOMMAIL:Category>
>> [6741][2018-11-23T21:05:14+00:00] I:       </POOMMAIL:Categories>
>> [6741][2018-11-23T21:05:14+00:00] I:      </Data>
>> [6741][2018-11-23T21:05:14+00:00] >>>:
>> Horde_Core_ActiveSync_Driver::changeMessage(INBOX, 398024 ...)
>> [6741][2018-11-23T21:05:14+00:00] >>>: Adding flags to the IMAP
>> server. [6741][2018-11-23T21:05:14+00:00] >>>: STATE: Updating
>> state during flags [6741][2018-11-23T21:05:14+00:00] I:
>> </Modify>
>>
>> If you can include the enclosing <SYNC> tag too, that would be
>> best.
>
> What's the most significant part of this snippet?

The entire <Modify> entry.

The error you are seeing is occurring, because for some reason, the  
value for the 'categories' entry in the internal array structure we  
use for transporting changes is not the expected array. This value  
defaults to an empty array and only be changed (by adding new category  
elements to the array) if the incoming change contains a categories  
node.

The fix I linked to fixes the case where the EAS client transmits an  
*empty* categories node - which was leading to the categories array  
element to be empty(), and not an empty array.  So, I'm asking to see  
the <Modify> node of a request that causes this error for you so I can  
see exactly what is being sent and determine why your categories  
change element is not the expected array.


> I can't find any
> reference to "Category" at all, though there are a couple of
> references to "Categories" matching up with occurrences of the PHP
> error, but many other occurrences of the PHP error logged with no
> corresponding reference to "Categories".

If you are seeing <Categories> nodes with no <Category> entries, that  
is exactly the case that the patch I linked to is supposed to fix.  
Please provide that <Modify> node.

> I wasn't seeing any
> references to "changeMessage", adding flags or updating state in any
> of the ActiveSync per-device logs at all until I set the log level to
> detailed.  I'm now seeing a few references to changeMessage, but they
> don't correspond with anything to do with Categories.
>
> - ----
> Nels Lindquist
> <[email protected]>
>
>
> --
> Horde mailing list
> Frequently Asked Questions: http://horde.org/faq/
> To unsubscribe, mail: [email protected]



-- 
mike
The Horde Project
http://www.horde.org
https://www.facebook.com/hordeproject
https://www.twitter.com/hordeproject

-- 
Horde mailing list
Frequently Asked Questions: http://horde.org/faq/
To unsubscribe, mail: [email protected]
(unnamed) (application/pgp-keys, 9.1 KB) - not displayed
signature.asc (application/pgp-signature, 821 B)