Re: Progress update

Hugo Palma <[email protected]> Fri, 17 Feb 2006 11:07:37 +0000
Newsgroups gmane.comp.ide.eclipse.spindle.devel
Message-ID <[email protected]>
I have some questions regarding these last changes, maybe i'm not yet seeing
the big picture and taking the risk of making a fool of myself here goes
anyway.

If i'm guessing right the goal of adding the depth in the lookups is to
support the new paging naming with paths right ?
Still, after looking at the code i ended up with after this change, it
started to look like the lookup and search could be merged into one. Maybe
i'm seeing this the wrong way but isn't doing a IResourceRoot.getSearch the
same as doing a IResourceRoot.lookup(requestor, LookupDepth.INFINITE) ?

I see only one diference now between search and root, when i call lookup the
actual lookup is performed instantly, with the getSearch you can choose when
to perform the search and also specify different ISearchAcceptor to each
search. Still, it think that with some changes in the API the two could be
merged to only one operation.

Any sense out of this ?

Cheers

Hugo

On 16/02/06, Geoff Longman <[email protected]> wrote:
>
> Spent a few hours implementing the new flavour of Resource lookups in
> the resource API and the test implementation.
>
> The test implementation is there but I need to write a few tests so I
> have not commited it.
>
> I have committed the core api changes though. Also commited classes in
> the core that were impacted by the change. These are internal
> implmentations classes so it should not affect anyone but me.
>
> Summary of core api changes:
>
> removed ResourceExtension#getSearch() and moved it to IResourceRoot.
> So ICoreResource no longer has the method getSerach(). (both
> IResourceRoot and ICoreResource implement ResourceExtension)
>
> added an enum called LookupDepth - ZERO (the current folder only) and
> INFINITE - (the current folder and all subfolders).
>
> changed
>
> ResourceExtension#lookup(IResourceAcceptor requestor) to
>
> ResourceExtension#lookup(IResourceAcceptor requestor, LookupDepth depth)
>
> Geoff
>
>
>
> --
> The Spindle guy.          http://spindle.sf.net
> Get help with Spindle:
> http://lists.sourceforge.net/mailman/listinfo/spindle-user
> Blog:                     http://jroller.com/page/glongman
> Feature Updates:          http://spindle.sf.net/updates
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid3432&bid#0486&dat1642
> _______________________________________________
> Spindle-developer mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/spindle-developer
>