Re: FriBracketType
Dov Grobgeld <[email protected]> Tue, 14 Nov 2017 19:07:04 +0200
| Newsgroups | gmane.comp.internationalization.fribidi |
|---|---|
| Message-ID | <CA++fsGG0gJ8HuqmgMNS7kmRihoZAbseYkjQw71fdqMJn_WAKsg@mail.gmail.com> |
--===============1143788288== Content-Type: multipart/alternative; boundary="f403045c18c69750ba055df46ad5" --f403045c18c69750ba055df46ad5 Content-Type: text/plain; charset="UTF-8" Fixed in commit:0e273c1. (And of course in my previous mail I meant 0x7ffffff...) Regards, Dov On Tue, Nov 14, 2017 at 1:31 PM, Dov Grobgeld <[email protected]> wrote: > No reason, except if bracket_id would be greater than 0x3fffffff, which is > not very likely. I'll change it before the release. > > Dov > > > On Tue, Nov 14, 2017 at 4:10 AM, Behdad Esfahbod <[email protected]> > wrote: > >> Any reason the bracket-type cannot be a single FriBidiChar, with the top >> bit used to indication open/close? It's wasteful the way it is right now: >> >> struct _FriBracketTypeStruct { >> FriBidiChar bracket_id; >> fribidi_boolean is_open; >> }; >> >> -- >> behdad >> http://behdad.org/ >> > > --f403045c18c69750ba055df46ad5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he= lvetica,sans-serif">Fixed in commit:0e273c1. (And of course in my previous = mail I meant 0x7ffffff...)</div><div class=3D"gmail_default" style=3D"font-= family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_default" s= tyle=3D"font-family:arial,helvetica,sans-serif">Regards,</div><div class=3D= "gmail_default" style=3D"font-family:arial,helvetica,sans-serif">Dov<br></d= iv></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Tue, = Nov 14, 2017 at 1:31 PM, Dov Grobgeld <span dir=3D"ltr"><<a href=3D"mail= to:[email protected]" target=3D"_blank">[email protected]</a>>= </span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .= 8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div clas= s=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif">No rea= son, except if bracket_id would be greater than 0x3fffffff, which is not ve= ry likely. I'll change it before the release.</div><span class=3D"HOEnZ= b"><font color=3D"#888888"><div class=3D"gmail_default" style=3D"font-famil= y:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_default" style= =3D"font-family:arial,helvetica,sans-serif">Dov</div><div class=3D"gmail_de= fault" style=3D"font-family:arial,helvetica,sans-serif"><br></div></font></= span></div><div class=3D"HOEnZb"><div class=3D"h5"><div class=3D"gmail_extr= a"><br><div class=3D"gmail_quote">On Tue, Nov 14, 2017 at 4:10 AM, Behdad E= sfahbod <span dir=3D"ltr"><<a href=3D"mailto:[email protected]" target= =3D"_blank">[email protected]</a>></span> wrote:<br><blockquote class=3D= "gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding= -left:1ex"><div dir=3D"ltr">Any reason the bracket-type cannot be a single = FriBidiChar, with the top bit used to indication open/close?=C2=A0 It's= wasteful the way it is right now:<br><br>struct _FriBracketTypeStruct { <b= r>=C2=A0 FriBidiChar bracket_id; <br>=C2=A0 fribidi_boolean is_open; <br>};= <br><span class=3D"m_499572464746171438HOEnZb"><font color=3D"#888888"><di= v><br>-- <br><div class=3D"m_499572464746171438m_-315054422434703915gmail_s= ignature">behdad<br><a href=3D"http://behdad.org/" target=3D"_blank">http:/= /behdad.org/</a></div> </div></font></span></div> </blockquote></div><br></div> </div></div></blockquote></div><br></div> --f403045c18c69750ba055df46ad5-- --===============1143788288== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZnJpYmlkaSBt YWlsaW5nIGxpc3QKZnJpYmlkaUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmliaWRpCg== --===============1143788288==--