[openi18n-im:01602] Re: 'im-sdk/branches/exp-remake-hotkey-impl' branch

Date: Fri, 19 May 2006 17:52:12 +0900 (JST)
From: AShiZaWa KaZuNoRi <[email protected]>:
> Hi,
> 
> I've just started to look around source code changes.
> 
> Date: Mon, 15 May 2006 14:17:35 +0900
> From: rev 3133 - in branch
> > Index: branches/exp-remake-hotkey-impl/lib/iiimp/data/comp-hotkeys.c
> > ===================================================================
> > --- branches/exp-remake-hotkey-impl/lib/iiimp/data/comp-hotkeys.c	(revision 3132)
> > +++ branches/exp-remake-hotkey-impl/lib/iiimp/data/comp-hotkeys.c	(revision 3133)
> > @@ -20,6 +20,11 @@
> 
> Good finding that comp-hotkeys.c is incomplete.  Unlike most of
> libiiimp.so functions, hotkey related implementations are not
> yet fully reviewed.
> 
> The problem exists in data life cycle management.  Design policy
> of libiiimp.so data life cycle management is: when a parent
> object is destroyed, all child objects are destroyed
> automatically.
> 
> So the fix would be to convert HOTKEY_LIST structure into linked
> list like IIIMP_string.  I'll try to fix this later.
> 
> By the way, the name HOTKEY_LIST (HOTKEYCTRL, HOTKEY) violates
> the other design policy: symbol names must start with IIIMP,
> IIIMF, iiimp, or iiimf, to avoid possible name space conflict.
> I will fix this name space issue, too.

I've committed the change as trunk revision 3142.

Thanks,
-- 
kasha