[openi18n-im:01138] Re: Progress of hotkey implementation
Hideki Hiura <[email protected]>
| Newsgroups | gmane.comp.internationalization.input-methods |
|---|---|
| Message-ID | <[email protected]> |
> From: Hideki Hiura <[email protected]> > > From: Hideki Hiura <[email protected]> > > > From: Roger So <[email protected]> > > > One thing, though; is there a reason for xiiimp.so to disable the > > > automatic hotkey handling by libiiimcf? > > > > I guess it is just a bug? :-). > > I should have said that the code has been there for long time, and due > to the transition from TRIGGERKEY based operation to HOTKEY based > operation, some assumtions in the code expecting TRIGGERKEY behavior > might be changed. > > I do not recall why it was needed straight out of my head right now :-O. Looked into the code more and recalled that this disabling was to incorporate the XResource based keybinding for XIM client. The xiiimp.so handles TriggerNotify by itself so that the additional Triggerkeys defined via XResource also works as if yet another TriggerKey. But due to the Triggerkey to Hotkey transition, the iiimcf_create_trigger_notify_event() and sending it via iiimcf_forward_event() does not seem to work. (This is the real bug of not correctly mapping trigger_notify related event to hotkey_notify event in libiiimcf). > > > When I commented out the code in iiimcfFun.c, everything seems to work fine. > > Would you send us a patch(or commit it in)? > > I guess you've commented out the following code right? > > st = iiimcf_attr_put_integer_value(attr, > IIIMCF_ATTR_DISABLE_AUTOMATIC_TRIGGER_NO\TIFY, > 1); Because of this bug, commenting out this line would work. If we do not need XResource based XIM only additional keybinding, the code around this functionality is not needed. So at least until this bug is fixed one way or the other, commenting this line out is fine. Hideki