Re: gtkpod 2 ... heading towards releasing

On 04/01/11 18:01, Daniele Forsi wrote:
> 2011/1/3 phantomjinx:
>
>    
>> Yeah. Its because the fetchcover service is used in the two separate
>> plugins, ie. cover_display and details editor. The fetchcover service
>> operates by dragging n dropping an image onto the relevant canvas, which
>> them downloads and copies the image. In both plugins, it is possible to do
>> this thus both plugins need the service. However, I didnt want it in the
>> core library since it is an optional service. Unfortunately, it is
>> impossible for plugins to depend on each other so I am left with replicating
>> it since both plugins are completely independant on one another.
>>      
> ok
> the following line can be removed? I builds without warnings.
>
> $ diff -u ./plugins/cover_display/fetchcover.c
> ./plugins/details_editor/fetchcover.c
> --- ./plugins/cover_display/fetchcover.c	2010-12-15 16:50:25.000000000 +0100
> +++ ./plugins/details_editor/fetchcover.c	2010-12-15 16:50:25.000000000 +0100
> @@ -37,7 +37,6 @@
>   #include "libgtkpod/misc.h"
>   #include "plugin.h"
>   #include "fetchcover.h"
> -#include "display_coverart.h"
>
>   #undef FETCHCOVER_DEBUG
>
>
>    
Yeah, seems ok.  Will commit later on.

Cheers

PGR

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl