Re: libgpod memory leaks

On 02/03/11 17:59, Jorg Schuler wrote:
> Thanks Peter.
>
> I'm forwarding your mail to the devel list. Please consider signing up.
>
> Cheers,
>
>
> JCS.
>
> On 03/02/2011 03:23 PM, Peter Hoepfner wrote:
>    
>> Hi,
>>
>> I am currently experimenting with libgpod 0.8.0 and I have lots of
>> memory leaks here.
>> Here are two I was able to track down already:
>> in itdb_itunesdb.c itdb_resolve_path()
>> instead of
>> -----------------------------------------------------------------------------------------
>>      file_stdcase = g_utf8_casefold(file_utf8,-1);
>>      found = !g_utf8_collate(file_stdcase,component_stdcase);
>>      g_free(file_stdcase);
>>      if(!found)
>>      {
>>          /* This is not the matching entry */
>>          g_free(file_utf8);
>>          continue;
>>      }
>> consider
>> ------------------------------------------------------------------------------------------
>>      file_stdcase = g_utf8_casefold(file_utf8,-1);
>>      g_free(file_utf8);
>>      found = !g_utf8_collate(file_stdcase,component_stdcase);
>>      g_free(file_stdcase);
>>      if(!found)
>>      {
>>          /* This is not the matching entry */
>>          continue;
>>      }
>> -------------------------------------------------------------------------------------------------------
>>
>>
>> and in itdb_itunesdb.c itdb_free()
>> please
>> add--------------------------------------------------------------------------------------
>>      g_list_foreach (itdb->priv->mhsd5_playlists,
>>          (GFunc)(itdb_playlist_free), NULL);
>> ----------------------------------------------------------------------------------------------------
>>
>>
>>
>> If I find more I'll let you know.
>>
>> Thank you
>> - Peter
>>
>>
>>      
Committed.

Regards

PGR

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev