Re: smart playlists: case sensitivity of string comparisons

Christophe Fergeau <[email protected]> Thu, 7 Jul 2011 22:33:47 +0200
Newsgroups gmane.comp.ipod.gtkpod
Message-ID <20110707203347.GA11251@merlin>
Hi James,

Sorry it took me an eternity to answer to your email :(

On Sat, Oct 30, 2010 at 09:14:48PM +0100, James Burton wrote:
> This would be a trivial change (using strcasecmp/strcasestr/strncasecmp
> in itdb_splr_eval in itdb_playlist.c), but I don't know if this issue has
> come up before and the current behaviour was deemed preferable.
> 
> Thoughts?

I don't think the case sensitive match was done on purpose, it's more than
noone has brought it up so far imo :) So your patch is really helpful!
However, I reworked it so that it handles non-ASCII UTF-8 strings as well,
see
http://gitorious.org/~teuf/libgpod/teuf-sandbox/commit/b35c72da7e3a73d031cdf4200eadc3145436336b
(disclaimer, I haven't tested it yet ;)

Let me know if that's fine with you, thanks again for the patch, and I'm
really sorry for the huge delay in answering :(

Christophe

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

_______________________________________________
Gtkpod-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
signature.asc (application/pgp-signature, 198 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4WGCsACgkQJKRp+3pW946L8ACgwYLH2/PoRKsKWl75WcEAk64/
efoAoMH4BKCgsggz4PTUt7lToLKr/Rq/
=Bq1j
-----END PGP SIGNATURE-----