Re: [PATCH] itdb_tzinfo.c: handle more iPod classic sizes (6g)

Hi,

On Tue, May 31, 2011 at 04:12:05AM +0100, Adeodato Simó wrote:
> ---
> Hi,
> 
> this tiny patch (adding one extra possible size for the Preferences
> file) fixes timezone recognition in my 6g iPod Classic.
> 
> I've tested it:
> 
>   - the get-timezone.c program prints correct values for Europe/Dublin
>     (local timezone in the computer) and Europe/Madrid (not local
>     timezone in the computer), UTC+1 and UTC+2 respectively (we're on
>     DST at the moment)
> 
>   - reading a LE 32-bit integer at byte 0xb70 in my Preferences file
>     yields the expected city IDs (0x4b when the timezone is Dublin in
>     the iPod; 0x62 for Madrid).
> 
> I'd be grateful if you could apply it.

Ah, the size of the Preferences file changed for some iPod Classic? Do you
know what generation your iPod Classic is? (if you don't, the last 3 digit
of the serial number will do). What firmware are you using?
I can't check which size is this file on my classic because of
https://lkml.org/lkml/2011/5/25/248 :( I'll try rebooting on OS X later.
These questions aside, your patch looks good, thanks.

Christophe

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

_______________________________________________
Gtkpod-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4WG4sACgkQJKRp+3pW94509ACgknUdAd5oeLPG7fpa5YWnBEfk
UCkAoIZSh6nvD0rAiLuilF7yLOZ9JxHP
=o7jF
-----END PGP SIGNATURE-----