Re: gtkpod fails to build in debian, patch

On Wed, 2012-10-03 at 18:11 +0100, phantomjinx wrote:
> "Brent S. Elmer Ph.D." <[email protected]> wrote:
>         gtkpod fails to build in debian testing.  It gives the following error:
>         
>         clarity_cover.c:244:9: error: format not a string literal and no format
>         arguments [-Werror=format-security]
>         
>         I fixed the problem like this:
>         
>         gtkpod-2.1.2/plugins/clarity/clarity_cover.c
>         
>             // Set cover artwork
>             gtk_clutter_texture_set_from_pixbuf
>         (GTK_CLUTTER_TEXTURE(priv->texture), item->albumart, &error);
>             if (error) {
>         +       g_warning("%s", error->message);
>         -       g_warning(error->message);
>                 g_error_free(error);
>                 return;
>             }
>         
>         After the fix gtkpod compiled.
>         
>         
>         
>         
>         ______________________________________________________________
>         
>         Don't let slow site performance ruin your business. Deploy New Relic APM
>         Deploy New Relic app performance management and know exactly
>         what is happening inside your Ruby, Python, PHP, Java, and .NET app
>         Try New Relic at no cost today and get our sweet Data Nerd shirt too!
>         http://p.sf.net/sfu/newrelic-dev2dev
>         
>         ______________________________________________________________
>         
>         Gtkpod-devel mailing list
>         [email protected]
>         https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
> 
> Thanks. Little perplexed why that would be a compile error ...
> 
> PGR

Maybe the debian source package and build uses some special flags that
make it a compiler error(probably -Werror=format-security).  By the way,
there are also some deprecated warnings.  If it helps, here is the
compile command as from the debian build process:

  CC     libclarity_la-clarity_cover.lo
/bin/sh ../../libtool --silent --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H
-I. -I../..  -DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\"
-DGTKPOD_DATA_DIR=\"/usr/share/gtkpod/data\"
-DGTKPOD_PLUGIN_DIR=\"/usr/lib/i386-linux-gnu/gtkpod\"
-DGTKPOD_IMAGE_DIR=\"/usr/share/gtkpod/icons\"
-DGTKPOD_GLADE_DIR=\"/usr/share/gtkpod/data/glade\"
-DGTKPOD_SCRIPT_DIR=\"/usr/share/gtkpod/scripts\"
-DGTKPOD_UI_DIR=\"/usr/share/gtkpod/data/ui\" -DPACKAGE_DATA_DIR=\"/usr/share\"
-DPACKAGE_SRC_DIR=\".\" -I../.. -g -O2 -fstack-protector --param=ssp-buffer-
size=4 -Wformat -Werror=format-security -Wall -Wno-pointer-sign -std=gnu99
-Werror-implicit-function-declaration -pthread -I/usr/include/gtk-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12   -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include   -pthread -I/usr/include/gtk-3.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include    -pthread -I/usr/include/gpod-1.0
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/libxml2
-I/usr/include/p11-kit-1   -pthread -I/usr/include/libxml2
-I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12 -I/usr/include/libanjuta-3.0   -pthread
-I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0 -I/usr/include/libxml2
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12   -I/usr/include/libxml2
-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES
-DGTK_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE -pthread -I/usr/include/clutter-
gtk-1.0 -I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0
-I/usr/include/pango-1.0 -I/usr/include/cogl -I/usr/include/cairo
-I/usr/include/atk-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pixman-1
-I/usr/include/gio-unix-2.0/   -pthread -I/usr/include/gstreamer-0.10
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/libxml2   -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/pixman-1
-I/usr/include/libpng12 -I/usr/include/brasero3   -pthread
-I/usr/include/libxml2 -I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libanjuta-3.0
-D_FORTIFY_SOURCE=2 -pthread -I/usr/include/clutter-gtk-1.0
-I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/cogl -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include
/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0/
-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-
security -Wall -Wno-pointer-sign -std=gnu99 -Werror-implicit-function-
declaration -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
-I/usr/include/libpng12   -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include   -pthread -I/usr/include/gtk-3.0 -I/usr/include/gio-
unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gdk-
pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
-pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-pthread -I/usr/include/gpod-1.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12
-I/usr/include/libxml2 -I/usr/include/p11-kit-1   -pthread
-I/usr/include/libxml2 -I/usr/include/gtk-3.0 -I/usr/include/libgdl-3.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/libanjuta-3.0
-pthread -I/usr/include/libgdl-3.0 -I/usr/include/gtk-3.0
-I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-
gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12
-I/usr/include/libxml2     -DG_DISABLE_SINGLE_INCLUDES
-DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES
-DGSEAL_ENABLE -pthread -I/usr/include/clutter-gtk-1.0
-I/usr/include/clutter-1.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0
-I/usr/include/cogl -I/usr/include/cairo -I/usr/include/atk-1.0 -I/usr/include
/json-glib-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/gio-unix-2.0/
-pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/i386
-linux-gnu/glib-2.0/include -I/usr/include/libxml2   -pthread
-I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include
-I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12
-I/usr/include/brasero3   -c -o libclarity_la-clarity_cover.lo `test -f
'clarity_cover.c' || echo './'`clarity_cover.c
clarity_cover.c: In function 'clarity_cover_set_album_item':
clarity_cover.c:244:9: error: format not a string literal and no format
arguments [-Werror=format-security]
clarity_cover.c: In function 'clarity_cover_clear_rotation_behaviour':
clarity_cover.c:293:5: warning: 'clutter_behaviour_is_applied' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:164) [-Wdeprecated-declarations]
clarity_cover.c:294:9: warning: 'clutter_behaviour_remove' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:143) [-Wdeprecated-declarations]
clarity_cover.c: In function 'clarity_cover_set_rotation_behaviour':
clarity_cover.c:310:9: warning: 'clutter_behaviour_rotate_new' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-behaviour-
rotate.h:82): Use 'clutter_actor_animate' instead [-Wdeprecated-declarations]
clarity_cover.c:317:9: warning: 'clutter_behaviour_rotate_set_center' is
deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour-rotate.h:93) [-Wdeprecated-declarations]
clarity_cover.c:322:9: warning: 'clutter_behaviour_apply' is deprecated
(declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-
behaviour.h:140) [-Wdeprecated-declarations]
cc1: some warnings being treated as errors
make[5]: *** [libclarity_la-clarity_cover.lo] Error 1
make[5]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins/clarity'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins/clarity'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/usr/local/src/gtkpod-2.1.2/plugins'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/local/src/gtkpod-2.1.2'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/local/src/gtkpod-2.1.2'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Build command 'cd gtkpod-2.1.2 && dpkg-buildpackage -b -uc' failed.
E: Child process failed

Brent




------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev