Re: [gtpd-cvs] [gtkpod] add mp4 chapter reading support to Atomic Parsley bridge

2012/11/11 Joel Smith:

> commit 3fbdec07724f4806f88dd93ac3927162b2cdaabd
> Author: Joel Smith <[email protected]>
> Date:   Thu Nov 8 14:23:35 2012 -0700
>
>     add mp4 chapter reading support to Atomic Parsley bridge
>
>  libs/atomic-parsley/AtomicParsleyBridge.cpp |  125 +++++++++++++++++++++++++--
>  1 files changed, 119 insertions(+), 6 deletions(-)
> ---
> diff --git a/libs/atomic-parsley/AtomicParsleyBridge.cpp b/libs/atomic-parsley/AtomicParsleyBridge.cpp
> index ef1a182..704fd3b 100644
> --- a/libs/atomic-parsley/AtomicParsleyBridge.cpp
> +++ b/libs/atomic-parsley/AtomicParsleyBridge.cpp

> +                {
> +                    // chapter title couldn't be found; create our own titles
> +                    // (and some ipods don't display them anyway)
> +                    title = g_strdup_printf("Chapter %3d", i);
> +                }

can we make that title translatable?
title = g_strdup_printf(_("Chapter %3d"), i);
and since translators will see the comments above that line, I'd
change them a bit, something like:
// Translators: this string is used to create a title when chapter
title couldn't be found
// (some iPods don't display them anyway)

is this related to a specific media or it could be anything (music,
movies, audiobooks)?
Not a big deal, but in Italian I would translate "chapter" differently
when it is related to music WRT other types
-- 
Daniele Forsi

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov