fix for sorttab bug-no selecting at all possible(probably 64 bit issue)
Benno <[email protected]> Fri, 15 Feb 2013 17:30:35 +0100
| Newsgroups | gmane.comp.ipod.gtkpod |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--------------060603000709060308010106
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Hello,
I'd like to submit a patch fixing an issue on 64Bit Linux,
which was introduced after the stable release gtkpod-2.1.2,
and is contained in the stable release gtkpod-2.1.3!
It was not possible to make any selection with the "track filter",
at least it hadn't any effect on the "playlist tracks".
(Normally if you select an artist, the "playlist tracks" would only show
the tracks of that artist)
The reason was the comparison of different sized(at least in 64 bit systems)
unsigned types, that were set to "-1"
1)in _NormalSortTabPagePrivate
guint selection_changed_idle_id;
2)in _st_selection_changed()
gulong idleId
Hope, this patch helps!
Greetings,
Benno
--------------060603000709060308010106
Content-Type: text/plain; charset=ISO-8859-1;
name="gtkpod-sorttab.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="gtkpod-sorttab.patch"
diff --git a/plugins/sorttab_display/normal_sorttab_page.c b/plugins/sorttab_display/normal_sorttab_page.c
index ee00304..0fb3286 100644
--- a/plugins/sorttab_display/normal_sorttab_page.c
+++ b/plugins/sorttab_display/normal_sorttab_page.c
@@ -66,7 +66,7 @@ struct _NormalSortTabPagePrivate {
* Handler id of the idle callback when the selection
* changed callback is executed
*/
- guint selection_changed_idle_id;
+ gulong selection_changed_idle_id;
/* name of entry last selected */
GList *last_selection;
--------------060603000709060308010106
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
--------------060603000709060308010106
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Gtkpod-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel
--------------060603000709060308010106--