Re: fix for sorttab bug-no selecting at all possible(probably 64 bit issue)
Daniele Forsi <[email protected]> Thu, 28 Feb 2013 22:17:21 +0100
| Newsgroups | gmane.comp.ipod.gtkpod |
|---|---|
| Message-ID | <CAN_we7M+59S36_QuGtZqPt2mZ2FSmFTtbnn=i0=gnw27-dPXDQ@mail.gmail.com> |
2013/2/28 phantomjinx: > On 02/15/2013 06:16 PM, Daniele Forsi wrote: >> 2013/2/15 Benno: >> >>> The reason was the comparison of different sized(at least in 64 bit systems) >>> unsigned types, that were set to "-1" >>> 1)in _NormalSortTabPagePrivate >>> guint selection_changed_idle_id; >>> 2)in _st_selection_changed() >>> gulong idleId >> >> I committed your fix >> http://sourceforge.net/mailarchive/message.php?msg_id=30490651 >> >> but now I think I misunderstood and I think I should revert it and >> change idelId to guint instead because struct member >> selection_changed_idle_id is assigned the return value from >> gdk_threads_add_idle_full() which indeed is a guint. What do you >> think? >> > > Hey Daniele, > > Did anything come from this in the end? thank you for reminding this, hopefully now I have committed a fix changing the type of the variable and the value of NO_IDLE_SELECTION_CALLBACK to zero which according to the docs is never returned by gdk_threads_add_idle_full () -- Daniele Forsi ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb