8/20 bytes uuid

--===============8759002064545490174==
Content-Type: multipart/alternative; boundary=001a1134f2bee57a8a04f35df1cc

--001a1134f2bee57a8a04f35df1cc
Content-Type: text/plain; charset=UTF-8

Hi.

UUID in hashing parameters is not 20bytes always.

https://github.com/denydias/libhashab#libgpod-extension-to-make-it-talk-to-ipod-nano-6th-generation

On iPod nano 6g, uuid (mean FirewireGuid) 8bytes. So uuid contains bytes
which isn't zero-filled.
Below is a patch.
Please check and include.


diff --git a/src/itdb_device.c b/src/itdb_device.c
index c72dd45..80995de 100644
--- a/src/itdb_device.c
+++ b/src/itdb_device.c
@@ -1899,7 +1899,7 @@ gboolean itdb_device_get_hex_uuid (const Itdb_Device
*device, unsigned char uuid
         return FALSE;
     }
     memset (uuid, 0, 20);
-    result = itdb_hex_from_string (uuid, 20, uuid_str);
+    result = itdb_hex_from_string (uuid, strlen (uuid_str) / 2, uuid_str);

     return (result == 0);
 }

-- 
- Yasuhiro Matsumoto

--001a1134f2bee57a8a04f35df1cc
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi.</div><div><br></div><div>UUID in hashing paramete=
rs is not 20bytes always.</div><div><br></div><div><a href=3D"https://githu=
b.com/denydias/libhashab#libgpod-extension-to-make-it-talk-to-ipod-nano-6th=
-generation">https://github.com/denydias/libhashab#libgpod-extension-to-mak=
e-it-talk-to-ipod-nano-6th-generation</a></div>
<div><br></div><div>On iPod nano 6g, uuid (mean FirewireGuid) 8bytes. So uu=
id contains bytes which isn&#39;t zero-filled.</div><div>Below is a patch.<=
/div><div>Please check and include.</div><div><br></div><div><br></div>
<div>diff --git a/src/itdb_device.c b/src/itdb_device.c</div><div>index c72=
dd45..80995de 100644</div><div>--- a/src/itdb_device.c</div><div>+++ b/src/=
itdb_device.c</div><div>@@ -1899,7 +1899,7 @@ gboolean itdb_device_get_hex_=
uuid (const Itdb_Device *device, unsigned char uuid</div>
<div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return FALSE;</div><div>=C2=A0 =C2=
=A0 =C2=A0}</div><div>=C2=A0 =C2=A0 =C2=A0memset (uuid, 0, 20);</div><div>-=
 =C2=A0 =C2=A0result =3D itdb_hex_from_string (uuid, 20, uuid_str);</div><d=
iv>+ =C2=A0 =C2=A0result =3D itdb_hex_from_string (uuid, strlen (uuid_str) =
/ 2, uuid_str);</div>
<div>=C2=A0</div><div>=C2=A0 =C2=A0 =C2=A0return (result =3D=3D 0);</div><d=
iv>=C2=A0}</div><div><br></div>-- <br>- Yasuhiro Matsumoto<br>
</div>

--001a1134f2bee57a8a04f35df1cc--


--===============8759002064545490174==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
--===============8759002064545490174==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Gtkpod-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-devel

--===============8759002064545490174==--