ispman/lib/ISPMan/DNSMan MXrecords.pm,1.24,1.25

Joerg Delker <[email protected]>
Newsgroups gmane.comp.isp.ispman.cvs
Message-ID <[email protected]>
Update of /cvsroot/ispman/ispman/lib/ISPMan/DNSMan
In directory sc8-pr-cvs11.sourceforge.net:/tmp/cvs-serv16657/lib/ISPMan/DNSMan

Modified Files:
	MXrecords.pm 
Log Message:
added new method "deleteDnsMxRecord"

Index: MXrecords.pm
===================================================================
RCS file: /cvsroot/ispman/ispman/lib/ISPMan/DNSMan/MXrecords.pm,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -d -r1.24 -r1.25
--- MXrecords.pm	4 Aug 2004 17:31:53 -0000	1.24
+++ MXrecords.pm	6 Jun 2006 17:12:28 -0000	1.25
@@ -10,6 +10,7 @@
   editDNSmXRecords
   modifyDNSmXRecord
   addDNSmXRecord
+  deleteDNSmXRecord
   getDNSmXRecords
   getFirstMX
 );
@@ -38,7 +39,7 @@
             push @{ $self->{'domain'}{'dns'} },
               {
                 'origion' => $h->{$hdn}{'relativeDomainName'},
-		'ttl'  => $h->{$hdn}{'DNSTTL'},
+                'ttl'  => $h->{$hdn}{'DNSTTL'},
                 'pref'    => $pref,
                 'host'    => $host
               };
@@ -79,30 +80,28 @@
 sub modifyDNSmXRecord {
     my $self = shift;
     my $r    = shift;
+    my $dn   = $r->param("dn");
+    
+    # delete old record
+    $self->deleteEntry( $dn );
 
-    # add/update record or delete?
-    if ( $r->param("host") and $r->param("origion") and $r->param("pref") ) {
-
-        # delete old record
-        $self->deleteEntry( $r->param("dn") );
+    # add record
+    $self->addDNSmXRecord($r);
+}
 
-        # add record
-        $self->addDNSmXRecord($r);
-    }
-    else {
+sub deleteDNSmXRecord {
+    my $self = shift;
+    my $r    = shift;
+    my $dn   = $r->param("dn");
 
-# FIXME
-# Quick&Dirty Patch to delete record. Better do this with direct action in web form
-        my $entry = $self->getEntry( $r->param("dn") );
-        $self->deleteDNSRecord(
+    my $entry = $self->getEntry( $dn );
+    $self->deleteDNSRecord(
             $r->param("ispmanDomain"),
             "mXRecord",
             $entry->get_value("relativeDomainName"),
             $entry->get_value("mXRecord")
-        );
-        $self->editDNSmXRecords($r);
-    }
-
+    );
+    $self->editDNSmXRecords($r);
 }
 
 sub getFirstMX {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.