ispman/ispman-web/cgi-bin/tmpl/modules editModule.tmpl, 1.10, 1.11

Joerg Delker <[email protected]> Mon, 20 Nov 2006 18:22:00 +0000
Newsgroups gmane.comp.isp.ispman.cvs
Message-ID <[email protected]>
Update of /cvsroot/ispman/ispman/ispman-web/cgi-bin/tmpl/modules
In directory sc8-pr-cvs2.sourceforge.net:/tmp/cvs-serv5013/ispman-web/cgi-bin/tmpl/modules

Modified Files:
	editModule.tmpl 
Log Message:
fixed [ 1599829 ] failure on empty confVars

Index: editModule.tmpl
===================================================================
RCS file: /cvsroot/ispman/ispman/ispman-web/cgi-bin/tmpl/modules/editModule.tmpl,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- editModule.tmpl	3 Oct 2006 17:17:12 -0000	1.10
+++ editModule.tmpl	20 Nov 2006 18:21:58 -0000	1.11
@@ -2,63 +2,75 @@
    
 
    
+<script language="JavaScript1.1">
+  function checkForm(f){
+    msg = ""
+    for(var i = 0; i < f.length; i++) {
+      var e = f.elements[i];
+      if (e.type == "text" && ((e.value == null) || (e.value == ""))) {
+        alert(e.name + " must not be empty");
+        return false;
+      }
+    }
+    return true;
+  }
+</script>
 
- <P>
 <table class=table border=0>
-<form method="POST">
-                                           
-
+  <form method="POST">
+  
         <perl>
         my $text="";
-		my $vars=$ispman->getConfVars($r->param('module'));
+        my $vars=$ispman->getConfVars($r->param('module'));
 
-		for (keys %$vars){
-			$ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanQuestion'}=$vars->{$_}{'ispmanQuestion'};
-			$ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanVal'}=$vars->{$_}{'ispmanVal'};
-			$ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanVarAlias'}=$vars->{$_}{'ispmanVarAlias'};
-		}
+        for (keys %$vars){
+            $ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanQuestion'}=$vars->{$_}{'ispmanQuestion'};
+            $ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanVal'}=$vars->{$_}{'ispmanVal'};
+            $ispmanVars->{$vars->{$_}{'ispmanVar'}}{'ispmanVarAlias'}=$vars->{$_}{'ispmanVarAlias'};
+        }
 
 
-		my $module=$r->param("module");
-		if ($ispman->{'Config'}{'ispmanVarSort'}{$module}){
-			my $varSort=$ispman->{'Config'}{'ispmanVarSort'}{$module};
-			my ($varDN, $ispmanQuestion, $ispmanVarAlias, $ispmanVar, $ispmanVal);
-		
-			for (@$varSort){
-				
-				$ispmanVar=$_;
-				$ispmanVal=$ispmanVars->{$_}{'ispmanVal'};
-				$ispmanQuestion=$ispmanVars->{$_}{'ispmanQuestion'};
-				$ispmanVarAlias=$ispmanVars->{$_}{'ispmanVarAlias'};
+        my $module=$r->param("module");
+        if ($ispman->{'Config'}{'ispmanVarSort'}{$module}){
+            my $varSort=$ispman->{'Config'}{'ispmanVarSort'}{$module};
+            my ($varDN, $ispmanQuestion, $ispmanVarAlias, $ispmanVar, $ispmanVal);
+        
+            for (@$varSort){
+                
+                $ispmanVar=$_;
+                $ispmanVal=$ispmanVars->{$_}{'ispmanVal'};
+                $ispmanQuestion=$ispmanVars->{$_}{'ispmanQuestion'};
+                $ispmanVarAlias=$ispmanVars->{$_}{'ispmanVarAlias'};
 
-				$text.="<tr class=list><td colspan=2><i>$ispmanQuestion</i></td></tr>\n";
-				$text.=qq|
-				<tr>
-				<td class=menuheader><p title="$ispmanVar">@{[($ispmanVarAlias)?$ispmanVarAlias:$ispmanVar]}</p></td>
-				<td><input type="text" name="$ispmanVar" size=40 value="$ispmanVal"></td>
-				</tr>|;
+                $text.="<tr class=list><td colspan=2><i>$ispmanQuestion</i></td></tr>\n";
+                $text.=qq|
+                <tr>
+                <td class=menuheader><p title="$ispmanVar">@{[($ispmanVarAlias)?$ispmanVarAlias:$ispmanVar]}</p></td>
+                <td><input type="text" name="$ispmanVar" size=40 value="$ispmanVal"></td>
+                </tr>|;
 
-			}
-		} else {
-			for (keys %$vars){
-				$text.="<tr class=list><td colspan=2><i>$vars->{$_}{'ispmanQuestion'}</i></td></tr>\n";
-				$text.=qq|
-				<tr>
-				<td class=menuheader><p title="$vars->{$_}{'ispmanVar'}">@{[($vars->{$_}{'ispmanVarAlias'})?$vars->{$_}{'ispmanVarAlias'}:$vars->{$_}{'ispmanVar'}]}</p></td>
-				<td><input type="text" name="$vars->{$_}{'ispmanVar'}" size=40 value="$vars->{$_}{'ispmanVal'}"></td>
-				</tr>|;
-			}
-		}
+            }
+        } else {
+            for (keys %$vars){
+                $text.="<tr class=list><td colspan=2><i>$vars->{$_}{'ispmanQuestion'}</i></td></tr>\n";
+                $text.=qq|
+                <tr>
+                <td class=menuheader><p title="$vars->{$_}{'ispmanVar'}">@{[($vars->{$_}{'ispmanVarAlias'})?$vars->{$_}{'ispmanVarAlias'}:$vars->{$_}{'ispmanVar'}]}</p></td>
+                <td><input type="text" name="$vars->{$_}{'ispmanVar'}" size=40 value="$vars->{$_}{'ispmanVal'}"></td>
+                </tr>|;
+            }
+        }
         $text
         </perl>
 
-        <input type=hidden name="module" value="<perl>$r->param("module")</perl>">
-        <input type=hidden name="mode" value="modifyModule">
-   <tr><td colspan=2 align=right>  
+      <tr><td colspan=2 align=right>
+         <input type=hidden name="module" value="<perl>$r->param("module")</perl>">
+         <input type=hidden name="mode" value="modifyModule">
          <input type=button class="button" onClick="document.forms[0].reset()" value="Discard Changes">
-         <input type=button class="button" onClick="document.forms[0].submit()" value="Save Entry">
+         <input type=button class="button" onClick="checkForm(this.form) && document.forms[0].submit()" value="Save Entry">
       </td></tr>
-   </form></table>
+   </form>
+</table>
  
  
 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV