Re: cvs: ispman/ispman/bin/ispman.makelogs

Andreas John wrote:
> Hello All!

Hi Andreas!

> I found in ispman.makelogs (Revision: 1.25.2.1, Tue Aug 10 20:54:29 2004
> UTC (9 months, 3 weeks ago) the following line:

First of all, I recommend *not* using the dev_1_3-bigcleanup branch from
cvs (which you obviously do, when using rev 1.25.2.1 ;)
That branch was a start to do code cleanup, which eventually led me to
do a fresh code rewrite for an all new 2.0 version.
So, if you want something quite stable, stick to the main trunk (HEAD).

> ----
> if ( ISPMan::Config->get("ispmanVhostsStyle") =~ /dir/m ) {
> ----
> 
> Could it be that the line should be like like this:
> 
> ----
> if ( ISPMan::Config->get("apacheVhostsStyle") =~ /dir/m ) {
> ----
>
> I do not fully understand why ispman.makelogs does need to know about
> the config hash at all, but IMHO the current line will never match
> "dir", at least not in the LDAP export of my installations.

Your change looks pretty reasonable, and was just commited to CVS (Thanks!).
BTW: ispman.makelogs was quite unmaintained in the past, since not many
people use their own log/stat mechanisms.

Joerg