Re: [PR] improve filtering performance [ant]

bodewig commented on PR #212:
URL: https://github.com/apache/ant/pull/212#issuecomment-2927252950

   as I said I'm not opposed to merging it, it will mostly be "a refactoring".
   
   I wondered whether an extra check whether we've used all slots of the temporary array and avoiding `copyOf` alltogether in some cases may be an additional improvement. In very many cases DirectoryScanner will not hit any symlinks during the scan at all. Then again the performance of DirectoryScanner very likely is dominated by filesystem I/O and there really is not much of a difference anyway. The extra-check would make the code more difficult to read for little real gain.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]