Re: [PR] Added a new DownloadProgress class to Get.java to display a progress bar. [ant]

mhdirkse (via GitHub) <[email protected]>
Newsgroups gmane.comp.jakarta.ant.devel
Message-ID <PR_kwDOATT2FM6qe5ru-38138d71-48f5-4395-92fe-f857bff93f5b@gitbox.apache.org>
mhdirkse commented on code in PR #224:
URL: https://github.com/apache/ant/pull/224#discussion_r2417166911


##########
src/main/org/apache/tools/ant/taskdefs/Get.java:
##########
@@ -90,9 +86,9 @@ public class Get extends Task {
     private boolean tryGzipEncoding = false;
     private Mapper mapperElement = null;
     private String userAgent =
-        System.getProperty(MagicNames.HTTP_AGENT_PROPERTY,
-                           DEFAULT_AGENT_PREFIX + "/"
-                           + Main.getShortAntVersion());

Review Comment:
   You have a lot of changes that are only styling. Some developers do not like that because it makes reviewing harder. And maybe the styling that the developers of this project want is different from what you are doing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.