Re: [PR] IVY-1658: merge `ivy-module` namespaces [an t-ivy]

bodewig commented on code in PR #111:
URL: https://github.com/apache/ant-ivy/pull/111#discussion_r2809723522


##########
src/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParser.java:
##########
@@ -722,6 +716,17 @@ public void mergeExcludes(ExcludeRule[] excludeRules) {
             }
         }
 
+        private void mergeNamespaces(Map<String, String> namespaces) {
+            if (namespaces != null && !namespaces.isEmpty()) {
+                for (Map.Entry<String, String> entry : namespaces.entrySet()) {
+                    Message.debug("Merging extra attribute namesapce: " + entry);
+                    if (getMd().getExtraAttributesNamespaces().get(entry.getKey()) == null) {

Review Comment:
   Actually if the module is written as `m:...` even though the prefix `m` is not defined at all then the way XML is written by Ivy is broken - which is quite possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]