Re: [PR] IVY-1614, IVY-1655: translate dynamic ranges to Maven-compatible formats [ant-ivy]

eric-milles commented on code in PR #126:
URL: https://github.com/apache/ant-ivy/pull/126#discussion_r3492248790


##########
src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorWriter.java:
##########
@@ -226,6 +230,31 @@ private static void indent(PrintWriter out, int indent) {
         }
     }
 
+    /**
+     * Translates dynamic revision to Maven-compatible version string.
+     */
+    private static String translate(String version) {
+        version = version.trim();
+        if (version.endsWith("+")) { // 1+, 1.+, 1.2+, 1.2.+
+            version = version.replaceFirst("\\.?\\s*\\+$", ""); // drop dot-plus

Review Comment:
   just being careful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]