Re: [PR] Cyclonedx [ant]

jaikiran commented on code in PR #233:
URL: https://github.com/apache/ant/pull/233#discussion_r3610049709


##########
sboms/ant-1.10.18alpha.cdx.json:
##########
@@ -0,0 +1,355 @@
+{
+  "bomFormat" : "CycloneDX",
+  "specVersion" : "1.6",
+  "serialNumber" : "urn:uuid:2b3c6004-1754-4985-bbf1-27f088f2b856",
+  "version" : 1,
+  "metadata" : {
+    "timestamp" : "2026-06-07T12:52:38Z",
+    "lifecycles" : [
+      {
+        "phase" : "build"
+      }
+    ],
+    "tools" : {
+      "components" : [
+        {
+          "type" : "library",
+          "supplier" : {
+            "name" : "Apache Ant Project Management Committee",
+            "url" : [
+              "https://ant.apache.org/"
+            ]
+          },
+          "manufacturer" : {
+            "name" : "Apache Ant Project Management Committee",
+            "url" : [
+              "https://ant.apache.org/"
+            ]
+          },
+          "publisher" : "The Apache Software Foundation",
+          "group" : "org.apache.ant",
+          "name" : "ant-cyclonedx",
+          "version" : "0.1",
+          "description" : "Apache CycloneDX Antlib",
+          "licenses" : [
+            {
+              "license" : {
+                "id" : "Apache-2.0",
+                "url" : "https://www.apache.org/licenses/LICENSE-2.0.txt"
+              }
+            }
+          ],
+          "purl" : "pkg:maven/org.apache.ant/[email protected]?type=jar",
+          "externalReferences" : [
+            {
+              "type" : "vcs",
+              "url" : "https://gitbox.apache.org/repos/asf/ant-antlibs-cyclonedx.git"
+            },
+            {
+              "type" : "license",
+              "url" : "https://www.apache.org/licenses/LICENSE-2.0.txt"
+            },
+            {
+              "type" : "build-system",
+              "url" : "https://ci-builds.apache.org/job/Ant/job/CycloneDX%20Antlib/"

Review Comment:
   Hello Stefan, for issue tracker, mailing list links, I think having a very precise link with the project id in it is worth it. So what you have for those right now looks good to me. To me those links are more user facing because they are used by actual users to either initiate a discussion or file issues. Plus the backing infrastructure for those (like the Ant project in the issue tracker) is much more official.
   
   On the other hand, the CI jobs link pointing to the exact job, I feel is a bit adhoc. And I don't think many users actual would be using that link. So for the `build-system` type, I think it might be OK to either leave that type out completely or just point to the top level `https://ci-builds.apache.org`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]