Re: Things to do before the next Ant release?!
Emmanuel Bourg <[email protected]>
| Newsgroups | gmane.comp.jakarta.ant.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Stefan, Le 08/08/2026 à 12:32, Stefan Bodewig a écrit : > * Is my change to DateUtils#getNow fine as it is or should I separate > the "override the notion of now" and "we want reproducible build" > questions? If we opt for the latter, what should be the signal, is it > the presence of SOURCE_DATE_EPOCH (as in getNow) or something else? > And what should be "now" if it is something else? Thinking further about it, instead of DateUtils.getNow() I'd suggest adding a Project.getBuildDate() or Project.getDate() method. That looks more natural and clearly communicates what the date represents. Also the fact that getNow() returns a date that is not now is a bit counterintuitive. Regarding Project.isReproducibleBuild(), I’m not sure it's needed. One could argue that builds should always be reproducible by default, so there shouldn't be a strong use case for querying that state explicitly. Emmanuel Bourg