Re: [PATCH] Eliminate circular dependency between altrmi and phoenix
Paul Hammant <[email protected]>
| Newsgroups | gmane.comp.jakarta.avalon.apps.devel,gmane.comp.jakarta.avalon.devel |
|---|---|
| Message-ID | <[email protected]> |
Sam, Thanks, but Phoenix and Cornerstone no longer depend on AltRMI (or never did). It must be gump entries that are wrong. I deleted one dep from the gump for cornerstone, but did not add any for the gump for altrmi (for two reasons: grok and locn of that gump file). Your suggestion is not so bad though, so I may well apply it. Especially as the blocks will require integration unit testing under punit control. - Paul --- Sam Ruby <[email protected]> wrote: > Altrmi now has code for blocks, which introduces dependencies on > cornerstone and phoenix. Cornerstone has code which depends on altrmi, > phoenix indirectly has a similar compilation dependency. > > What I would like to be able to do is to compile the "core" of altrmi > first - i.e., everything except the blocks. If that is successful, then > compilation can proceed to phoenix and cornerstone. If each of these is > successful, then an attempt will be made to go back and compile the > altrmi blocks with the latest phoenix and cornerstone class definitions. > > Patch below > > Index: build.xml > =================================================================== > RCS file: /home/cvs/jakarta-avalon-excalibur/altrmi/build.xml,v > retrieving revision 1.55 > diff -u -r1.55 build.xml > --- build.xml 27 Dec 2002 00:07:27 -0000 1.55 > +++ build.xml 27 Dec 2002 12:04:28 -0000 > @@ -9,6 +9,7 @@ > <property file="${basedir}/default.properties"/> > <property file="${user.home}/.ant.properties"/> > <property file="default.properties"/> > + <available property="block.present" > classname="org.apache.avalon.phoenix.BlockEvent"/> > > > <property name ="jetty.rel" value="4.2.2"/> > @@ -105,6 +106,7 @@ > target="1.2"> > <classpath refid="project.class.path" /> > <include name="**/*.java"/> > + <exclude name="org/apache/excalibur/altrmi/blocks/**" > unless="block.present"/> > <exclude > name="org/apache/excalibur/altrmi/server/impl/http/*.java" > unless="jetty.present"/> > </javac> > > @@ -166,7 +168,7 @@ > > </target> > > - <target name="metagenerate" description="Generates the XML descriptors"> > + <target name="metagenerate" if="block.present" description="Generates > the XML descriptors"> > > <taskdef name="generatemeta" > classname="org.apache.avalon.phoenix.tools.metagenerate.MetaGenerateTask"> > <classpath refid="project.class.path" /> > > - Sam Ruby > > > > > -- > To unsubscribe, e-mail: <mailto:[email protected]> > For additional commands, e-mail: <mailto:[email protected]> > __________________________________________________ Do You Yahoo!? Everything you'll ever need on one web page from News and Sport to Email and Music Charts http://uk.my.yahoo.com