Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/handler ComponentFactory.java

Stephen McConnell wrote:
> Re: the following change to the Fortress ComponentFactory.java:
> 
>  +            final String message = "WARNING: " + 
> m_componentClass.getName() +
>  +                " implements the Composable lifecycle stage. This is " +
>  +                " a deprecated feature that will be removed in the 
> future. " +
>  +                " Please upgrade to using Serviceable.";
>  +            getLogger().warn( message );
>  +            System.out.println( message );
> 
> Is this level of noise necessary.  Firstly, I think the System.out is 
> uneccessary and has the potential to become annoying for anyone with 
> large numbers of Composable components.

+1. Printing messages to system.out is annoying in general; its why we 
have logging :D

>  Secondly, the log message at 
> the level of "warn" seems to me to be excessive. I would consider a 
> debug level log as much more appropriate.

don't think so; debug is disabled in most production systems. Would it 
make you happy if "that will be removed in the future" were to be snipped?

We really do want our users to move away from Composable. How we should 
tell them is a bit of a matter of preference. Some annoyance is good :D

cheers,

- Leo