Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/impl/handler ComponentFactory.java
Nicola Ken Barozzi <[email protected]> Wed, 19 Mar 2003 15:16:50 +0100
| Newsgroups | gmane.comp.jakarta.avalon.phoenix.devel,gmane.comp.jakarta.turbine.maven.devel |
|---|---|
| Organization | Apache Software Foundation |
| Message-ID | <[email protected]> |
Leo Simons wrote, On 19/03/2003 15.01: > Stephen McConnell wrote: > >> Re: the following change to the Fortress ComponentFactory.java: >> >> + final String message = "WARNING: " + >> m_componentClass.getName() + >> + " implements the Composable lifecycle stage. This is >> " + >> + " a deprecated feature that will be removed in the >> future. " + >> + " Please upgrade to using Serviceable."; >> + getLogger().warn( message ); >> + System.out.println( message ); >> >> Is this level of noise necessary. Firstly, I think the System.out is >> uneccessary and has the potential to become annoying for anyone with >> large numbers of Composable components. > > > +1. Printing messages to system.out is annoying in general; its why we > have logging :D And it totally defeats our purpose of soft-deprecating Component stuff. -- Nicola Ken Barozzi [email protected] - verba volant, scripta manent - (discussions get forgotten, just code remains) ---------------------------------------------------------------------