loop limiter in BCELifier.printFlags
Yudhi Widyatama <[email protected]>
| Newsgroups | gmane.comp.jakarta.bcel.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
I'm wondering about the line 195 in
org/apache/bcel/util/BCELifier.java (trunk code in
SVN):
for (int i = 0, pow = 1; i <=
Constants.MAX_ACC_FLAG; i++) {
...
pow <<= 1;
}
If I understand this correctly, there is no need to do
the loop 0x4000 times (which is the value of
Constants.MAX_ACC_FLAG). I thought it would be better
like this:
for (int i = 0, pow = 1; i <
Constants.ACCESS_NAMES.length; i++) {
Pardon me if I'm wrong.
Regards,
Yudhi Widyatama
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com