Re: Feedback and Possible enhancements

Thanks for the first change. I would love to have a go at the
CompoundInstruction challenge, but unfortunately I'm tied up with adding
lots of code to Jakarta Commons at the moment.

One of the things I intend to add there is a class/method/field definition
structure. This was originally intended for introspecting existing classes
into, but I think it might also be useful for generating classes from.
Anyway, its just an idea at the moment, but I may be back in touch at some
point ;-)

Stephen

From: "Markus Dahm" <[email protected]>
>  > 1) InstructionFactory doesn't have a create method for INSTANCEOF. At
> first
>  > I assumed 'createCheckCast' would do it.
> Fixed.
>
>
>  > 2) Creating a try catch catch finally was a real pain. It was not
obvious
>  > that an exception type of null would create the finally part, and the
>  > arrangement of all the bytecodes seems like something that could be
>  > automated easily. Could I suggest something like:
>
>
> Byte code for finally is really ugly, but you can use the BCELifier to
> find out how to implement it.
>
> Your suggestion is just what the CompoundInstruction interface is
> intended for. However, such a template is not that simple to implement,
> since you have to consider where to store the exception references and
> the return address. Should this be passed by the user or be created
> automagically somehow?
>
> Feel free to implement such a template, I'll gladly add it to BCEL :)
>
> Cheers
> Markus
>
>
>
>
> --
> To unsubscribe, e-mail:   <mailto:[email protected]>
> For additional commands, e-mail: <mailto:[email protected]>
>