Re: [patch] BCELifier & BCELFactory

oops, sorry for the TABs, I have to check once more, where did Eclipse 
keep its TAB vs. 2 spaces settings...

Neeme Praks ::

> Some fixes:
> BCELifier:
> * package and class name handling was buggy with non-root packages
>
> BCELFactory:
> * code generation for createNewArray() method call was buggy: removed
> one extra quotation mark and made a explicit cast from int to short.
>
> As a result, the generated class should be able to compile now, without
> problems.
>
> Rgds,
> Neeme
>
>
>
> ------------------------------------------------------------------------
>
> Index: src/java/org/apache/bcel/util/BCELFactory.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-bcel/src/java/org/apache/bcel/util/BCELFactory.java,v
> retrieving revision 1.2
> diff -r1.2 BCELFactory.java
> 195,196c195,196
> <       _out.println("il.append(_factory.createNewArray(\"" +
> < 		   BCELifier.printType(type) + ", " + dim + "));");
> ---
>
> >      _out.println("il.append(_factory.createNewArray(" +
> >		   BCELifier.printType(type) + ", (short) " + dim + "));");
>
> Index: src/java/org/apache/bcel/util/BCELifier.java
> ===================================================================
> RCS file: 
> /home/cvspublic/jakarta-bcel/src/java/org/apache/bcel/util/BCELifier.java,v
> retrieving revision 1.2
> diff -r1.2 BCELifier.java
> 99a100,104
>
> >	if (!"".equals(package_name)) {
> >		class_name = class_name.substring(package_name.length() + 1);
> >		_out.println("package " + package_name + ";");
> >    	_out.println();
> >	}
>
>
>
>
> ------------------------------------------------------------------------
>
> --
> To unsubscribe, e-mail:
> For additional commands, e-mail: