[BCEL] Re: svn commit: r1081190 - /jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java

Hello Dave,

the build of bcel failed in gump [1] with compilation errors in 
TABLESWITCH and LOOKUPSWITCH [2].

Can you check whether your recent changes introduced the breakage and 
whether you can fix it ?

I noticed this because the failure of bcel triggered a failure of xalan 
which triggered a failure of ant in the gump run.

Regards,

Antoine

[1] 
http://vmgump.apache.org/gump/public/jakarta-bcel/bcel/gump_work/build_jakarta-bcel_bcel.html

[2]
/srv/gump/public/workspace/jakarta-bcel/src/main/java/org/apache/bcel/generic/TABLESWITCH.java:[104,9] visitStackProducer(org.apache.bcel.generic.StackProducer) in org.apache.bcel.generic.Visitor cannot be applied to (org.apache.bcel.generic.TABLESWITCH)

/srv/gump/public/workspace/jakarta-bcel/src/main/java/org/apache/bcel/generic/LOOKUPSWITCH.java:[94,9] visitStackProducer(org.apache.bcel.generic.StackProducer) in org.apache.bcel.generic.Visitor cannot be applied to (org.apache.bcel.generic.LOOKUPSWITCH)




On 3/13/2011 2:41 PM, [email protected] wrote:
> Author: dbrosius
> Date: Sun Mar 13 18:41:20 2011
> New Revision: 1081190
>
> URL: http://svn.apache.org/viewvc?rev=1081190&view=rev
> Log:
> Bug 48908 - Select instructions should implement StackConsumer instead of StackProducer
>
> Modified:
>      jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java
>
> Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java
> URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java?rev=1081190&r1=1081189&r2=1081190&view=diff
> ==============================================================================
> --- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java (original)
> +++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Select.java Sun Mar 13 18:41:20 2011
> @@ -33,7 +33,7 @@ import org.apache.bcel.util.ByteSequence
>    * @see InstructionList
>    */
>   public abstract class Select extends BranchInstruction implements VariableLengthInstruction,
> -        StackProducer {
> +        StackConsumer {
>
>       private static final long serialVersionUID = 2806771744559217250L;
>       protected int[] match; // matches, i.e., case 1: ...
>
>
>
>