Re: [VOTE] Release JMeter 2.5 RC1

Hello,

Thanks for your checkings.
I prefer stopping the vote for prepare a new RC2 including your comments

And this morning, I've found a (major) bug on Proxy behavior with HC4
sampler type.

Milamber

Le 01/08/2011 05:46, Stefan Bodewig a ecrit :
> On 2011-08-01, Milamber wrote:
>
>   
>> The first release candidate for JMeter 2.5 has been prepared, and your
>> votes are solicited.
>>     
> I haven't performed any sort of test, not even tried to build JMeter.
>
> * hashes and sigs are fine
>
> * source tarball and svn tag differ in some ways, some minor like no
>   checkstyle.xml in the source archive but at least one that might be
>   significant:
>
> diff -ur v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java
> --- v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java 2011-08-01 07:26:20.174097342 +0200
> +++ jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java       2011-08-01 01:18:26.000000000 +0200
> @@ -44,7 +44,7 @@
>       * This ensures that JMeterUtils always gets the correct
>       * version, even if JMeterUtils is not re-compiled during the build.
>       */
> -    private static final String VERSION = "2.5";
> +    private static final String VERSION = "2.5 r1152655";
>
>   For me this is not big enough to cast a negative vote, this really
>   depends on how closely the JMeter devs want the tag and the released
>   code to match.
>
> * in addition the source distribution is missing the docs subdirectory.
>   Is this intentional?
>
> * RAT only flags some testfiles, which is good enough for me
>
> * NOTICE should contain 2011 rather than 2010
>
> * ApacheJMeter.jar should probably not contain the tird party notice and
>   licenses but only the ASF ones as the files inside the jar only apply
>   to the jar and not the binary distribution.  No biggy for me.
>
> Not a +1, yet.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
>