Re: DO NOT REPLY [Bug 51866] [PATCH] Counter under loop doesn't work properly if "Start next loop on error" option set for thread group

--000e0cd5d050cebe6e04b021d4db
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hello Sebb,
I am looking at how to fix issues with "Start Next Loop".
Is there a way to get parent controller from child ? I don't see how ?
Would it be through a call to testTree.traverse and a SearchClass Controlle=
r
? but we would also take into account controller that are down the
hierarchy.

Regards
Philippe



On Wed, Oct 5, 2011 at 6:06 PM, <[email protected]> wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=3D51866
>
> --- Comment #8 from Sebb <[email protected]> 2011-10-05 16:06:50 UTC ---
> (In reply to comment #7)
> > If I put JMeterContextService.getContext().isWithinRestartNextLoop() te=
st
> > in fireIterEvents() instead,
> > do you see a case where it could fail ?
>
> Yes, if fireIterationStart() is called directly.
> But adding it to both won't necessarily help either, as that only fixes t=
he
> issue with iteration listeners.
>
> But as I pointed out in Comment 3, it's not just the counter that
> misbehaves;
> the counter problem is just one symptom.
>
> I think the whole "Start next loop" code needs rewriting.
>
> Effectively the option means "go to end of loop" for each controller up t=
o
> the
> Thread Group. [At least I assume this is the intention, as the option onl=
y
> appears on the Thread Group controller.]
>
> So we need to code the feature as if this has happened, and then everythi=
ng
> else should happen naturally.
>
> --
> Configure bugmail:
> https://issues.apache.org/bugzilla/userprefs.cgi?tab=3Demail
> ------- You are receiving this mail because: -------
> You voted for the bug.
> You are on the CC list for the bug.
>



--=20
Cordialement.
Philippe Mouawad.
Ubik-Ing=E9nierie

--000e0cd5d050cebe6e04b021d4db--