Re: Commons XML Factory draft

Hi Gary,

On 25.04.2026 16:29, Gary Gregory wrote:
> I have minor comments for now:
> 
> The name XmlFactories reads oddly to me. It's a factory that produces
> different kind of XML related objects, so I'd just call it XmlFactory.


It is a factory that produces factories for various XML
parsers/transformers/validators. XmlFactories sounds good to me (like
Arrays, Collections, Files, …), especially since almost every method is
of the form `newXFactory()`.

I asked an LLM to propose some alternatives. The best proposals seem:

- HardenedFactories, SecureFactories, SafeFactories,
- Xml, XmlSecurity, Jaxp.


> I would put everything in one package and let as much as possible be
> package private.


I moved all the classes to a single package in:

https://github.com/copernik-eu/commons-xml-factory/pull/6

XmlFactories is the only public class in the lot.

The SPI interface also seems unnecessary and XmlFactories could simply
dispatch calls directly to the appropriate hardening recipe. This is
done in:

https://github.com/copernik-eu/commons-xml-factory/pull/7

Piotr