Re: 1.4.2 Release Candidate Available

hi robert

On Saturday, May 3, 2003, at 04:37 PM, Robert Lowe wrote:

> Thanks for that, Robert. I'm going to run this for a while on my 
> development
> system--I'll let you know how I get on.

thanks very much.

> Incidentally, looking through the source on CVS, I noticed this method
> definition in org.apache.ecs.ConcreteElement:
>
> public void output(Writer out)
>     {
>         output ( new PrintWriter(out) );
>     }
>
> This looks like a bug--since PrintWriter buffers output, doesn't it need 
> to
> be flushed? As in:
>
> public void output(Writer out)
>     {
>         PrintWriter pw = new PrintWriter(out);
>         output (pw);
>         pw.flush();
>     }
>
> I'm just thinking this might cause problems as pretty much all the element
> classes inherit this method.

i agree with your analysis and i've committed a patch. this means that a 
second release candidate will be necessary but i'll do this once people 
have had a decent chance to test the first one and report any issues.

(just FYI this has been in ECS for a long time so it appears that the 
existing code doesn't cause too many problems in the wild.)

- robert