Re: [James 3.4.0] config broken

Hi Tommy,

Yes this problem is known for 3.4.0 JPA product, for example: 
https://www.mail-archive.com/[email protected]/msg16168.html

Replace it with :
<mailet matcher="All" class="WithPriority">
     <priority>8</priority>
</mailet>

We did fix it in the code but not for the release.

Cheers,
Rene.

On 13/03/2020 02:53, Tommy Pham wrote:
> Hello everyone,
> 
> I think the james 3.4.0 default configuration files are broken or the
> class(es) are not interpreting the configurations correctly.  I'm getting
> this error on startup:
> 
> Caused by: java.lang.IllegalArgumentException: 'priority' init parameter is
> compulsory
>          at
> org.apache.james.transport.mailets.WithPriority.lambda$init$0(WithPriority.java:54)
>          at java.base/java.util.Optional.orElseThrow(Optional.java:408)
>          at
> org.apache.james.transport.mailets.WithPriority.init(WithPriority.java:54)
>          at org.apache.mailet.base.GenericMailet.init(GenericMailet.java:229)
>          at
> org.apache.james.container.spring.bean.factory.mailetcontainer.MailetLoaderBeanFactory.getMailet(MailetLoaderBeanFactory.java:45)
>          ... 29 more
> 
> and it then stopped.  If I used the default configurations from 3.3, it
> startups OK listening on ports 25, 110, 143, and others:
> 
> USER     COMMAND    PID   FD PROTO  LOCAL ADDRESS         FOREIGN ADDRESS
> root     java       29741 224 tcp4  *:22421               *:*
> root     java       29741 268 tcp4  127.0.0.1:52860       *:*
> root     java       29741 291 tcp4  *:25                  *:*
> root     java       29741 307 tcp4  *:110                 *:*
> root     java       29741 323 tcp4  *:143                 *:*
> root     java       29741 324 tcp4  127.0.0.1:9999        *:*
> root     java       29741 325 tcp4  *:50052               *:*
> 
> Here's a diff of the configuration relating to the above error:
> 
> --- conf.3.3.0/mailetcontainer.xml      2019-05-29 08:56:41.325001000 -0700
> +++ conf.3.4.0/mailetcontainer.xml      2020-03-12 12:35:52.827179000 -0700
> @@ -56,7 +56,16 @@
>          <!-- Important check to avoid looping -->
>          <mailet match="RelayLimit=30" class="Null"/>
> 
> -       <!-- Check attachment extensions for possible viruses -->
> +        <mailet matcher="All" class="WithPriority">
> +            <value>8</value>
> +        </mailet>
> +
> +        <mailet matcher="HasPriority=8" class="Null"/>
> +        <mailet matcher="AtLeastPriority=8" class="Null"/>
> +        <mailet matcher="AtMostPriority=8" class="Null"/>
> +
> +
> +        <!-- Check attachment extensions for possible viruses -->
>          <!-- The "-z" option requests the check to be non-recursively
> applied -->
>          <!-- to the contents of any attached '*.zip' file. -->
>          <!--
> 
> Anyone experiencing other issues with James 3.4?  Other than storing /
> receiving mail?
> 
> Thanks,
> Tommy
>